Skip to content

fix: player can now MoveUp #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrcook wants to merge 2 commits into from
Closed

fix: player can now MoveUp #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccfcdb4
fix: player can now MoveUp
mrcook Jan 13, 2026
5356b1e
Trim some blank lines
mrcook Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions galactic-armada/src/main/states/gameplay/objects/player.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ InitializePlayer::
ld [wPlayerPositionX+1], a
ld [wPlayerPositionY+1], a


CopyPlayerTileDataIntoVRAM:
; Copy the player's tile data into VRAM
ld de, playerShipTileData
Expand Down Expand Up @@ -77,7 +77,7 @@ UpdatePlayer_HandleInput:
and PADF_A
call nz, TryShoot
; ANCHOR_END: player-update-start


; ANCHOR: player-update-flashing
ld a, [mPlayerFlash+0]
Expand All @@ -99,7 +99,7 @@ UpdatePlayer_UpdateSprite_CheckFlashing:
ld a, c
sbc 0
ld c, a


UpdatePlayer_UpdateSprite_DecreaseFlashing:

Expand Down Expand Up @@ -144,7 +144,7 @@ UpdatePlayer_UpdateSprite:
ld b, a
ld a, [wPlayerPositionX+1]
ld d, a

srl d
rr b
srl d
Expand All @@ -168,7 +168,7 @@ UpdatePlayer_UpdateSprite:
rr c
srl e
rr c

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
; Drawing the palyer metasprite
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
Expand Down Expand Up @@ -212,7 +212,7 @@ TryShoot:
; ANCHOR: player-damage
DamagePlayer::



xor a
ld [mPlayerFlash], a
Expand All @@ -234,9 +234,9 @@ MoveUp:
sub PLAYER_MOVE_SPEED
ld [wPlayerPositionY], a

ld a, [wPlayerPositionY]
ld a, [wPlayerPositionY+1]
sbc 0
ld [wPlayerPositionY], a
ld [wPlayerPositionY+1], a

ret

Expand Down