-
Notifications
You must be signed in to change notification settings - Fork 24
Add PSW related registers #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rangi42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, thanks for this! It would be great for the Pan Docs to cover these registers as well. (https://gbdev.io/pandocs/CGB_Registers.html#undocumented-registers is very sparse and doesn't mention $FF71.)
Co-authored-by: Rangi <[email protected]>
Co-authored-by: Rangi <[email protected]>
Co-authored-by: Rangi <[email protected]>
Co-authored-by: Rangi <[email protected]>
Thanks for reviewing. Yes, I hope to get on to updating the Pan Docs next. I also have a test ROM to release that verifies the register behaviour. |
ISSOtm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks good to me. Thank you!
I'm planning to release the source code for apparently.gb and so thought it would be nice to add these registers and constants for the PSW related registers.