Add Periodic Thread class and reduce YarpLoggerDevice latency#899
Draft
LoreMoretti wants to merge 25 commits intogbionics:masterfrom
Draft
Add Periodic Thread class and reduce YarpLoggerDevice latency#899LoreMoretti wants to merge 25 commits intogbionics:masterfrom
LoreMoretti wants to merge 25 commits intogbionics:masterfrom
Conversation
It is not clear why with the pure virtual run function, things do not work. It seems that the pure virtual function is being called, rather than the user override one. This causes a segmentation fault.
LoreMoretti
force-pushed
the
feature/PeriodicThread
branch
from
5342aeb to
2461257
Compare
LoreMoretti
changed the title
Contributor
Author
|
Also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class manages the creation and execution of periodic threads.
User can define the tasks for their periodic thread just by inheriting from this class and overriding the
threadInitandrunfunction.Indeed, this PR also changes the
YarpLoggerDevice, which now inherits fromBipedalLocomotion::System::PeriodicThreadrather thanyarp::os::PeriodicThread.