fix: remove redundant inits from _loaders/__init__.py (resolves #225)#233
Merged
satvshr merged 2 commits intogc-os-ai:mainfrom Feb 22, 2026
Merged
fix: remove redundant inits from _loaders/__init__.py (resolves #225)#233satvshr merged 2 commits intogc-os-ai:mainfrom
satvshr merged 2 commits intogc-os-ai:mainfrom
Conversation
Contributor
Author
|
@satvshr could you please review this PR? |
satvshr
reviewed
Feb 22, 2026
Collaborator
|
Thanks! Left a small comment. |
Contributor
Author
|
yeah i've updated the docstring to refrence (pyaptamer\datasets_init_.py) |
satvshr
approved these changes
Feb 22, 2026
Collaborator
satvshr
left a comment
satvshr
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR resolves #225 by removing all redundant
importstatements and the__all__list frompyaptamer/datasets/_loaders/__init__.py.As noted in the issue,
_loadersis a private directory, and exposing its contents in its own__init__.pyonly created unnecessary double-work when adding new dataset loaders to the project.please note that in this PR i did not delete the file.Closes #225