Skip to content

Two new options and stats#4

Open
inode64 wants to merge 16 commits intogcarq:masterfrom
inode64:master
Open

Two new options and stats#4
inode64 wants to merge 16 commits intogcarq:masterfrom
inode64:master

Conversation

@inode64
Copy link
Contributor

@inode64 inode64 commented Apr 22, 2021

  • Show last modified date and file size
  • Show size in human readable format

Show statistics

Signed-off-by: Fco Javier Felix ffelix@inode64.com

inode64 added 2 commits April 22, 2021 17:06
* Show last modified date and file size
* Show size in human readable format

Show statistics

Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
@gcarq
Copy link
Owner

gcarq commented Apr 23, 2021

@inode64 Please use snake_case for functions and variables. camelCase would be ok if the existing code would have the same style, but in this case its not. PascalCase should only used for classes and is a no-go for variable or function names

inode64 added 4 commits April 23, 2021 11:21
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
@inode64
Copy link
Contributor Author

inode64 commented Apr 23, 2021

If you consider changing the name of the parameters, it will be well received.
Thanks

inode64 added 7 commits April 23, 2021 12:23
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
-----------
Traceback (most recent call last):
  File "/root/lostfiles.py", line 684, in <module>
    main()
  File "/root/lostfiles.py", line 476, in main
    tracked = collect_tracked_files()
  File "/root/lostfiles.py", line 676, in collect_tracked_files
    files.update(normalize_filenames(fp.readlines()))
  File "/usr/lib/python-exec/python3.6/../../../lib64/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc5 in position 5799: ordinal not in range(128)

Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
In older server with bad locale it showed this error, I change to correct value and now it runs fine

Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
In older server with bad locale it showed this error, I change to correct value and now it runs fine

Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
@gcarq
Copy link
Owner

gcarq commented Apr 30, 2021

@inode64 I will review it the next days, didn't have time so far, sorry

@inode64
Copy link
Contributor Author

inode64 commented Apr 30, 2021

Do not worry. I have been checking my servers are about 72 of 64bits and 1 of 32, 1 desktop. Both with amd 17.1 and earlier and the tool seems to work well.
I already have new ideas to improve it.
Greetings

inode64 added 3 commits May 4, 2021 16:14
Show broken symlinks notice

Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
@inode64
Copy link
Contributor Author

inode64 commented Jun 21, 2021

have you been able to review this commit?

@gcarq
Copy link
Owner

gcarq commented Dec 27, 2022

Thanks for the PR and sorry for the long delay. However at this point I'm not confident in merging this as I want to keep it as minimal as possible and non-interactive to use it together with other scripts. I will keep it open in case more people ask for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants