Open
Conversation
github-actions
bot
added
bug
JR40159
requested changes
Mar 30, 2026
| return result.headers | ||
| } | ||
|
|
||
| export async function waitForImageTagManifest( |
Member
There was a problem hiding this comment.
If the issue is the tag not resolving, could we scan based on the digest hash?
ARADDCC002
requested changes
Mar 30, 2026
| // cover an edge case where scans are allowed with no delay (from config) causing a race condition | ||
| const existingScanInProgress = await ScanModel.findOne({ ...scanIdentifier, state: ArtefactScanState.InProgress }) | ||
| if (existingScanInProgress) { | ||
| throw InternalError('Cannot rescan an artefact while an existing scan is in progress', { |
Member
There was a problem hiding this comment.
A 500 response is normally for unexpected actions, but in this case, this is expected behaviour. I wonder if a 409 Conflict is better? Happy to debated this one, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inProgresscheck (to prevent DoS from same scan being re-requested, and fix a race condition)