Icon color components as doubles through pigeon#353
Merged
orkun1675 merged 1 commit intogdelataillade:mainfrom Mar 29, 2025
Merged
Icon color components as doubles through pigeon#353orkun1675 merged 1 commit intogdelataillade:mainfrom
orkun1675 merged 1 commit intogdelataillade:mainfrom
Conversation
orkun1675
approved these changes
Mar 29, 2025
Collaborator
orkun1675
left a comment
orkun1675
left a comment
There was a problem hiding this comment.
Thanks for the improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @orkun1675 pointed out, it's a better decision to pass the color components as doubles through pigeon.
In Kotlin, we still need to convert them from
DoubletoFloatfor passing them toColor.argb()method.