feat: keep notification after alarm ends (Fixes #328)#394
Merged
gdelataillade merged 1 commit intogdelataillade:mainfrom Jan 28, 2026
Merged
feat: keep notification after alarm ends (Fixes #328)#394gdelataillade merged 1 commit intogdelataillade:mainfrom
gdelataillade merged 1 commit intogdelataillade:mainfrom
Conversation
…mEnds' feature across platforms. - Updated data models and bindings for both Android and iOS to support this new functionality, ensuring notifications remain visible after alarms finish ringing. - Adjusted related logic in AlarmManager and notification handling to respect this setting.
Owner
|
Thanks for the PR @taha-elkholy ! I'll review it as soon as possible. |
Contributor
Author
|
Yes, Exactly. |
Owner
|
Added to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to keep the notification visible after the alarm stops ringing, as requested in issue #328.
Changes
keepNotificationAfterAlarmEndssetting in data modelsTesting
Issue reference
Resolves #328