Solved infinite fall issue.

[martinbelcic]

Add Checkpoint to Lv 1.

Please check if the PR fulfills these requirements:

• The commit message follows our guidelines.
• For bug fixes and features:
  • You tested the changes.
  • You updated the docs or changelog.

Related issue (if applicable): #187 #185

What kind of change does this PR introduce?
Added a Checkpoint on Level 1, which prevents the game from crashing if you hook multiple times to a single target. I've also created a new Death Zone scene which kills the player instantly to avoid falling endlessly

[NathanLovato]

Thanks for the contribution, but in this project, the player just shouldn't be able to fall in pits. If there's a missing wall in a given level, we should add it instead.

[NathanLovato]

Ah sorry, I had mistaken the project. We have so many repositories at the moment...

Yes so at the moment, the game is not finished and the player can fall indefinitely. However, I don't know if this is a good fix - Ideally, we shouldn't have to place the death colliders manually in every level - it's too error-prone. Also, your code doesn't match our GDScript guidelines. Please check them out to contribute: https://www.gdquest.com/docs/guidelines/best-practices/godot-gdscript/

[NathanLovato]

I have to think about the best way to address that. One level-agnostic way to do that is to have a counter on the player that keeps track of the fall height, and they die past a certain value.

Another option is to have a general death height variable on the Level or player that causes the player to die, maybe with some visual indicating the limits of the level both in the editor and in the game.