Skip to content

Conversation

@joamatab
Copy link
Contributor

@joamatab joamatab commented Apr 15, 2025

Summary by Sourcery

Update gdsfactory dependency and refactor component naming in various test files

New Features:

  • Upgrade gdsfactory to version 9.4.0

Enhancements:

  • Modify component naming conventions in test files
  • Update test files to use new gdsfactory naming patterns

Chores:

  • Clean up test files and remove unnecessary code

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 15, 2025

Reviewer's Guide by Sourcery

This pull request updates the gdsfactory dependency, renames components in netlist YAML files, adds warnings for unconnected ports, and adds code to delete the dkcells.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The component names in the YAML netlist files have been updated to reflect changes in the gdsfactory library.
  • Renamed component instances to align with the updated gdsfactory library.
  • Updated the names of grating coupler arrays.
  • Updated the names of rectangle components.
  • Updated the names of straight components.
  • Updated the names of compass components.
tests/test_si220/test_netlists_die_.yml
tests/test_si220/test_netlists_die_rc_.yml
tests/test_si220/test_netlists_die_ro_.yml
tests/test_si220/test_netlists_die_sc_.yml
tests/test_si220/test_netlists_die_so_.yml
tests/test_si500/test_netlists_die_.yml
tests/test_si500/test_netlists_die_rc_.yml
tests/test_si500/test_netlists_die_ro_.yml
tests/test_sin300/test_netlists_die_.yml
tests/test_sin300/test_netlists_die_nc_.yml
tests/test_sin300/test_netlists_die_no_.yml
tests/test_si220/test_netlists_coupler_straight_.yml
tests/test_si220/test_netlists_via_stack_heater_mtop_.yml
tests/test_si500/test_netlists_coupler_straight_.yml
tests/test_sin300/test_netlists_coupler_straight_.yml
Added warnings for unconnected vertical_te ports in grating coupler array netlists.
  • Added a warnings section to the netlist YAML files.
  • Included a message indicating the number of unconnected vertical_te ports.
  • Listed the ports that are unconnected.
  • Provided the coordinates of the unconnected ports.
tests/test_si220/test_netlists_grating_coupler_array_.yml
tests/test_si500/test_netlists_grating_coupler_array_.yml
tests/test_sin300/test_netlists_grating_coupler_array_.yml
Updated the gdsfactory dependency version.
  • Changed the gdsfactory version from 9.3.2 to 9.4.0 in pyproject.toml.
pyproject.toml
Added a centered parameter to the rectangle settings.
  • Added a centered parameter to the rectangle settings in the YAML file.
  • Set the centered parameter to false.
tests/test_si220/test_settings_rectangle_.yml
Added code to delete the dkcells.
  • Added code to delete the dkcells in the test files.
tests/test_si220.py
tests/test_si500.py
tests/test_sin300.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab merged commit 0b131c1 into main Apr 15, 2025
4 checks passed
@joamatab joamatab changed the title updata gdsfactory update gdsfactory 9.4.0 Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants