Skip to content

Conversation

@joamatab
Copy link
Contributor

@joamatab joamatab commented Apr 18, 2025

Summary by Sourcery

Update gdsfactory dependency to version 9.5.0 and modify routing behavior across multiple technology files

Enhancements:

  • Modify route_bundle function to set on_collision parameter to None by default in multiple technology files
  • Update example script in primitives.py to demonstrate crossing_so() component

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 18, 2025

Reviewer's Guide by Sourcery

This pull request updates the gdsfactory and gplugins dependencies, modifies the default collision behavior in the route_bundle function, and adds a call to pprint_ports to the crossing_so component.

Updated class diagram for route_bundle function

classDiagram
    class route_bundle {
      +min_straight_taper: float = 100.0
      +port_type: str | None = None
      +collision_check_layers: Iterable[LayerSpec] = ()
      -on_collision: str | None = "show_error"
      +on_collision: str | None = None
      +bboxes: list | None = None
      +allow_width_mismatch: bool = False
      +radius: float | None = None
    }
    note for route_bundle "The default value of on_collision has been changed from 'show_error' to None"
Loading

File-Level Changes

Change Details Files
Updated gdsfactory and gplugins dependencies.
  • Updated gdsfactory dependency from version 9.4.0 to 9.5.0.
  • Updated gplugins dependency from version >=1,<2 to version >=1.3.3,<2.
pyproject.toml
Modified the default collision behavior in the route_bundle function.
  • Changed the default value of the on_collision parameter in the route_bundle function from show_error to None.
cspdk/si220/tech.py
cspdk/si500/tech.py
cspdk/sin300/tech.py
Added a call to pprint_ports to the crossing_so component.
  • Added a call to c.pprint_ports() in the if __name__ == '__main__' block for the crossing_so component.
cspdk/si220/cells/primitives.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@joamatab joamatab changed the title update_gdsfactory_9.5.0 update_gdsfactory_9.5.0 and add bundle_sbend router Apr 18, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab added the enhancement New feature or request label Apr 18, 2025
@joamatab joamatab merged commit cf63643 into main Apr 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants