Skip to content

Conversation

@flaport
Copy link
Contributor

@flaport flaport commented May 1, 2025

Summary by Sourcery

Add port type specification to routing functions in the technology module

Enhancements:

  • Added port_type parameter to various routing function definitions
  • Specified 'optical' or 'electrical' port types for different routing strategies

Chores:

  • Updated gdsfactory dependency to version 9.5.5

@sourcery-ai
Copy link

sourcery-ai bot commented May 1, 2025

Reviewer's Guide

This pull request introduces a port_type parameter to various routing function partials in tech.py and updates the gdsfactory dependency.

File-Level Changes

Change Details Files
Add port_type parameter to routing functions
  • Added port_type="optical" to optical routing function partials.
  • Added port_type="electrical" to metal routing function partials.
cspdk/si220/tech.py
Update gdsfactory dependency
  • Bumped gdsfactory version from 9.5.0 to 9.5.5.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@github-actions github-actions bot added the enhancement New feature or request label May 1, 2025
@joamatab joamatab merged commit 6074cdc into main May 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants