update gdsfactory9.29.1

[joamatab]

• remove sample drc and update_gdsfactory9.26
• update gdsfactory

Summary by Sourcery

Update the project to use gdsfactory 9.29.1 and refresh sample layouts accordingly.

New Features:

• Add a sample script to generate and display a reticle containing all cells in the si220 cband PDK library.

Enhancements:

• Remove the outdated DRC error sample in favor of a comprehensive all-cells sample.

Build:

• Bump the gdsfactory dependency from 9.25.2 to 9.29.1.

[sourcery-ai]

Reviewer's Guide

Updates the project to use gdsfactory 9.29.1 and refreshes sample scripts by adding an all-cells reticle generator while removing the previous DRC error sample.

Sequence diagram for generating an all-cells reticle sample

sequenceDiagram
    actor User
    participant Script as all_cells_script
    participant PDK as PDK
    participant GF as gdsfactory

    User->>Script: Run module as __main__
    Script->>PDK: activate()
    PDK-->>Script: PDK configured

    User->>Script: Call all_cells()
    Script->>GF: Component()
    GF-->>Script: Component c

    Script->>PDK: Access cells
    PDK-->>Script: cells dictionary

    Script->>Script: Filter cells using skip
    Script->>GF: pack(cell_functions)
    GF-->>Script: packed_components_list

    Script->>GF: place first packed component into c

    Script-->>User: Return Component c

    User->>c: show()
    c-->>User: Display reticle layout

Loading

Flow diagram for all_cells sample reticle generation

flowchart TD
    A[Start all_cells] --> B[Create new Component c]
    B --> C[Read PDK.cells dictionary]
    C --> D[Filter out cells whose names are in skip]
    D --> E[Build list cell_functions]
    E --> F[Call gf.pack on cell_functions]
    F --> G[Select first packed component]
    G --> H[Add packed component into c]
    H --> I[Return Component c]

    subgraph Main_execution_when___name___is___main__
        J[Activate PDK]
        J --> K[Call all_cells]
        K --> L[Get Component c]
        L --> M[Call c.show]
        M --> N[Display reticle]
    end

Loading

File-Level Changes

Change	Details	Files
Bump gdsfactory dependency to version 9.29.1.	Update the gdsfactory version constraint in the project dependencies from 9.25.2 to 9.29.1. Keep other dependency versions unchanged to minimize impact.	pyproject.toml
Add a new sample script that generates a reticle containing all PDK cells.	Define an all_cells gf.cell that packs all cells from the active PDK into a single component, with optional skipping via a dictionary. Implement a main section that activates the PDK, builds the all_cells component, and displays it.	cspdk/si220/cband/samples/all_cells.py
Remove the previous DRC error sample script from the samples directory.	Delete the drc_errors sample file from the cband samples to clean up outdated or unnecessary examples.	cspdk/si220/cband/samples/drc_errors.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The skip dictionary in all_cells.py is currently unused and always empty; consider either removing it or wiring it as a parameter (or populating it) so it actually controls which cells are included.
• Accessing PDK.cells at module import time means all_cells() depends on the state of the PDK before PDK.activate() is called; consider moving the cell_functions lookup inside all_cells() after an explicit PDK.activate() call or clearly documenting the expected activation order.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The `skip` dictionary in `all_cells.py` is currently unused and always empty; consider either removing it or wiring it as a parameter (or populating it) so it actually controls which cells are included.
- Accessing `PDK.cells` at module import time means `all_cells()` depends on the state of the PDK before `PDK.activate()` is called; consider moving the `cell_functions` lookup inside `all_cells()` after an explicit `PDK.activate()` call or clearly documenting the expected activation order.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}