Skip to content

add test for GDSFactory+ #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joamatab wants to merge 8 commits into
base: main
Choose a base branch
from
Open

add test for GDSFactory+ #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
655c9f8
add test for gfp
joamatab Dec 2, 2025
e42d785
fix pre-commit
joamatab Dec 3, 2025
f3e4c03
fix make test
joamatab Dec 3, 2025
63d2baf
fix test
joamatab Dec 3, 2025
2a657af
Refactor GitHub Actions workflow for Python tests
nikosavola Dec 3, 2025
eb5971b
Remove gdsfactoryplus from docs dependency group
nikosavola Dec 3, 2025
6dd9349
Run GDSFactory+ from its own dependency group
nikosavola Dec 3, 2025
01ac5fd
No explicit `make install` where not needed
nikosavola Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
uses: astral-sh/setup-uv@v7.1.3
with:
python-version: ${{ matrix.python-version }}
- run: make install
- run: make setup-ipython-config
- run: make docs
- uses: actions/upload-artifact@v5
Expand Down
19 changes: 17 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
- main
merge_group:
workflow_dispatch:
permissions:
contents: read
env:
GFP_API_KEY: ${{ secrets.GFP_API_KEY }}
jobs:
pre-commit:
runs-on: ubuntu-latest
Expand All @@ -31,8 +35,6 @@ jobs:
uses: astral-sh/setup-uv@v7.1.3
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: make install
- name: Test with pytest
run: make test
test-code-result:
Expand All @@ -50,3 +52,16 @@ jobs:
echo "One or more test jobs failed"
exit 1
fi
test_gdsfactoryplus:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.12"]
steps:
- uses: actions/checkout@v6
- name: Install uv
uses: astral-sh/setup-uv@v7.1.3
with:
python-version: ${{ matrix.python-version }}
- name: Test GDSFactory+
run: uv run --group gdsfactoryplus gfp test
Comment on lines +55 to +67
Copy link
Member

@nikosavola nikosavola Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GDSFactory+ is running but failing. What is it exactly doing? It seems to fail at many sections where it assumes a layer or cross-section from the generic PDK would be available here. A SLAB90 layer in this PDK does not make sense for example.

.venv/lib/python3.12/site-packages/gdsfactory/pdk.py:713: in get_layer
    return get_active_pdk().get_layer(layer)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.venv/lib/python3.12/site-packages/gdsfactory/pdk.py:524: in get_layer
    raise ValueError(f"{layer!r} not in PDK {self.name!r} {layer_members}")
E   ValueError: 'SLAB90' not in PDK 'qpdk' OrderedDict({'M1_DRAW': <LayerMapQPDK.M1_DRAW: 1>, 'M1_ETCH': <LayerMapQPDK.M1_ETCH: 47>, 'M2_DRAW': <LayerMapQPDK.M2_DRAW: 3>, 'M2_ETCH': <LayerMapQPDK.M2_ETCH: 48>, 'AB_DRAW': <LayerMapQPDK.AB_DRAW: 49>, 'AB_VIA': <LayerMapQPDK.AB_VIA: 50>, 'JJ_AREA': <LayerMapQPDK.JJ_AREA: 13>, 'JJ_PATCH': <LayerMapQPDK.JJ_PATCH: 51>, 'IND': <LayerMapQPDK.IND: 52>, 'TSV': <LayerMapQPDK.TSV: 53>, 'DICE': <LayerMapQPDK.DICE: 38>, 'ALN_TOP': <LayerMapQPDK.ALN_TOP: 54>, 'ALN_BOT': <LayerMapQPDK.ALN_BOT: 55>, 'TEXT': <LayerMapQPDK.TEXT: 56>, 'LABEL_SETTINGS': <LayerMapQPDK.LABEL_SETTINGS: 30>, 'LABEL_INSTANCE': <LayerMapQPDK.LABEL_INSTANCE: 46>, 'SIM_AREA': <LayerMapQPDK.SIM_AREA: 57>, 'SIM_ONLY': <LayerMapQPDK.SIM_ONLY: 58>, 'WG': <LayerMapQPDK.WG: 59>})

Copy link
Contributor Author

@joamatab joamatab Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flaport any idea why this is happening?

7 changes: 4 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ clean: ##@ Clean up all build, test, coverage and Python artifacts
###########

PYTEST_COMMAND := uv run --group dev pytest
PYTEST_COMMAND_WITH_MODELS := uv run --extra models --group dev pytest
test: ##@ Run the full test suite in parallel using pytest
$(PYTEST_COMMAND) -n auto
$(PYTEST_COMMAND_WITH_MODELS) -n auto

test-gds: ##@ Run GDS regressions tests (tests/test_pdk.py)
$(PYTEST_COMMAND) -s tests/test_pdk.py
Expand Down Expand Up @@ -75,10 +76,10 @@ setup-ipython-config: ##@ Setup IPython configuration for documentation build
cp docs/qpdk.mplstyle ~/.config/matplotlib/stylelib/qpdk.mplstyle

docs: write-cells write-makefile-help copy-sample-notebooks ##@ Build the HTML documentation
uv run --group docs jb build docs
uv run --extra models --group docs jb build docs

docs-latex: write-cells write-makefile-help copy-sample-notebooks ##@ Setup LaTeX for PDF documentation
uv run --group docs jb build docs --builder latex
uv run --extra models --group docs jb build docs --builder latex

docs-pdf: docs-latex ##@ Build PDF documentation (requires a TeXLive installation)
cd "docs/_build/latex" && XINDYOPTS="-M sphinx.xdy" latexmk -pdfxe -xelatex -interaction=nonstopmode -f -file-line-error || (test -f qpdk.pdf && echo "PDF generated despite warnings" && exit 0)
7 changes: 4 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ docs = [
"sphinxcontrib-katex",
"sphinxcontrib-svgbob",
]
gdsfactoryplus = ["gdsfactoryplus"]
lint = ["prek"]
test = [
"hypothesis",
Expand Down Expand Up @@ -128,18 +129,18 @@ read-only = "ignore"
[tool.pytest]
addopts = ["--tb=short"]
norecursedirs = [
"extra/*.py",
"*.egg",
".*",
"CVS",
"_darcs",
"build",
"CVS",
"dist",
"extra/*.py",
"node_modules",
"venv",
"{arch}"
]
python_files = ["qpdk/*.py", "notebooks/*.ipynb", "tests/*.py"]
python_files = ["notebooks/*.ipynb", "qpdk/*.py", "tests/*.py"]
testpaths = ["qpdk/", "tests"]

[tool.ruff]
Expand Down
Loading