-
Notifications
You must be signed in to change notification settings - Fork 17
refactor(gear-idea/frontend,vara-eth-idea/frontend): share sails payload forms logic #2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the sails payload forms logic by extracting it into a new shared package @gear-js/sails-payload-form to enable code reuse between the gear-idea and vara-eth-idea frontends.
Changes:
- Created a new shared package
@gear-js/sails-payload-formcontaining reusable form components, utilities, hooks, and types for handling Sails payload forms - Updated both gear-idea/frontend and vara-eth-idea/frontend to use the new shared package, removing duplicate code
- Added workspace configuration and build setup for the new package
Reviewed changes
Copilot reviewed 82 out of 89 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/sails-payload-form/* | New shared package containing extracted sails payload form logic |
| idea/gear/frontend/src/features/sails/* | Removed duplicate code and integrated with shared package |
| idea/vara-eth/frontend/src/features/sails/* | Removed duplicate code and integrated with shared package |
| idea/gear/frontend/vite.config.ts | Added alias configuration for the shared package |
| idea/gear/frontend/tsconfig.app.json | Added path mapping for the shared package |
| idea/vara-eth/frontend/vite.config.ts | Added alias configuration for the shared package |
| idea/vara-eth/frontend/tsconfig.app.json | Added path mapping for the shared package |
| yarn.lock | Added workspace entry for the new package |
| package.json | Added the new package to workspaces |
| lerna.json | Added the new package to lerna configuration |
| eslint.config.mjs | Added the new package to ESLint configuration |
| idea/gear/frontend/Dockerfile | Updated yarn workspaces focus command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
db7ab54 to
849168d
Compare
255a0ba to
045e49a
Compare
045e49a to
33a6f2a
Compare
No description provided.