feat(ethexe): Added separate type for network announces

[Lazark0x]

Announce Hash-Only Refactor and NetworkAnnounce Wire Payload

Summary

This refactor splits announce representation into two layers:

1. Local/persisted/compute layer uses Announce with:
   • injected_transactions: Vec<HashOf<InjectedTransaction>>
2. Network transport layer uses NetworkAnnounce with:
   • injected_transactions: Vec<SignedInjectedTransaction>

The goal is to stop carrying full injected transaction bodies in every local announce iteration and use hash references locally, while still transferring full signed transactions over the network when needed.

---

Before vs After

Before

• Announce contained full Vec<SignedInjectedTransaction>.
• Announce traversal, tx validity-window scans, and other local logic repeatedly touched heavy tx bodies.
• db-sync announce payloads were local announce objects (full txs embedded).

After

• Announce contains only Vec<HashOf<InjectedTransaction>>.
• NetworkAnnounce carries full Vec<SignedInjectedTransaction> only for wire operations.
• Full tx bodies are persisted in injected-tx storage and fetched by hash only at boundaries that need them.

---

Type-Level Changes

1. Announce field changed in ethexe/common/src/primitives.rs:

   • from Vec<SignedInjectedTransaction>
   • to Vec<HashOf<InjectedTransaction>>

2. NetworkAnnounce lives in ethexe/common/src/primitives.rs:

   • block_hash
   • parent
   • gas_allowance
   • injected_transactions: Vec<SignedInjectedTransaction>
   • and is re-exported from ethexe/common/src/network.rs for network-facing API usage.

3. Network aliases switched:

   • ValidatorAnnounce = ValidatorMessage<NetworkAnnounce>
   • VerifiedAnnounce = VerifiedData<NetworkAnnounce>
   • AnnouncesResponse now stores Vec<NetworkAnnounce>

4. Conversion APIs on NetworkAnnounce:

   • impl From<&NetworkAnnounce> for Announce
   • impl From<NetworkAnnounce> for Announce
   • impl TryFrom<(Announce, Vec<SignedInjectedTransaction>)> for NetworkAnnounce
   • impl TryFrom<Announce> for NetworkAnnounce (for hash-only/empty-body test and utility cases)
   • to_hash() (hash of converted local Announce)
   • into_announce_persisting_injected_transactions(&db) to centralize:
     • persisting signed tx bodies to InjectedStorage
     • producing local hash-only Announce

---

What Changed for InjectedTransaction

Core rule

InjectedTransaction hash is the canonical ID used in local announce chains.

• Hash type: HashOf<InjectedTransaction>
• Derived from unsigned payload fields (destination, payload, value, reference_block, salt)
• Not a hash of the signed envelope

Practical impact

1. Announce chain now stores tx references (hashes), not full signed txs.
2. Signed tx bodies are persisted separately (InjectedStorage) keyed by tx hash.
3. Full signed tx body is loaded only when required:
   • network ingress/sync persistence
   • compute executable preparation
4. Missing tx body now has explicit failure paths.

---

End-to-End Data Flow

1) Producer path

Injected pool selection
    |
    v
Vec<SignedInjectedTransaction>
    |\
    | \-- map tx.data().to_hash() --------------------+
    |                                                 |
    v                                                 v
NetworkAnnounce (full tx bodies)                Announce (tx hashes only)
    |                                                 |
    | publish signed validator message                | include in DB
    |                                                 | emit ComputeAnnounce(local)
    v                                                 v
Network                                              Consensus/Compute pipeline

2) Network announce acceptance path (consensus)

VerifiedAnnounce<NetworkAnnounce> received
    |
    v
accept_announce(network_announce)
    |
    +-- convert to local announce (hash-only, via From impl)
    +-- validate each signed tx from network payload
    +-- persist each valid signed tx:
    |      set_injected_transaction(tx)
    +-- include local announce in announce storage
    |
    v
Emit ComputeAnnounce(local hash-only announce)

3) Missing-announces sync path

db-sync response: Vec<NetworkAnnounce>
    |
    v
for each network announce:
    network_announce.into_announce_persisting_injected_transactions(db)
      - persist signed tx bodies into InjectedStorage
      - convert to local Announce (hash list)
    pass (announce_hash, announce) to propagation

4) Compute path

ComputeAnnounce(Announce { tx_hashes... })
    |
    v
prepare_executable_for_announce
    |
    +-- for tx_hash in announce.injected_transactions:
    |      db.injected_transaction(tx_hash) -> SignedInjectedTransaction
    |      into_verified()
    |
    +-- if missing:
    |      ComputeError::InjectedTransactionNotFound(tx_hash)
    |
    v
ExecutableData with full verified txs

5) db-sync server response path

Local announce in DB (hash-only tx list)
    |
    v
For each tx_hash:
    db.injected_transaction(tx_hash) -> signed tx body
    else -> InjectedTransactionMissing error
    |
    v
Build NetworkAnnounce (full tx bodies) via validated constructor:
    NetworkAnnounce::try_from_announce(announce, injected_transactions)
    |
    v
Send InnerAnnouncesResponse(Vec<NetworkAnnounce>)

---

Hashing and Identity Semantics

There are two relevant hashes now:

1. Local announce hash (HashOf<Announce>)

   • computed over local announce fields where tx list is hashes
   • this is canonical for persistence, parent links, and chain checks

2. Signed validator message digest (for transport signing)

   • includes NetworkAnnounce payload encoding
   • used for network authenticity, not as local announce chain identity

NetworkAnnounce::to_hash() intentionally converts to local announce first (via From<&NetworkAnnounce>), then hashes. This keeps network-side validation aligned with local canonical announce hashing.

---

Storage Boundary (Important)

After the refactor:

• AnnounceStorage stores local announce bodies with tx hash references.
• InjectedStorage stores full SignedInjectedTransaction bodies.

This boundary is now explicit and central:

1. Ingress/sync side writes tx bodies to InjectedStorage.
2. Local announce graph carries only hashes.
3. Compute/db-sync server resolve hashes back to full bodies when needed.

---

Behavior and Error Handling Changes

1. Compute now explicitly errors if announce references a missing tx body:

   • ComputeError::InjectedTransactionNotFound(HashOf<InjectedTransaction>)

2. db-sync announce response building explicitly errors if tx hash cannot be resolved:

   • InjectedTransactionMissing { hash }
   • and also errors if announce hash-list and loaded tx bodies mismatch:
     • AnnounceInjectedTransactionsMismatch { hash, source }
     • where source is NetworkAnnounceFromAnnounceError

3. DB integrity verifier no longer rejects non-empty announce injected data,
   because non-empty hash lists in announces are valid by design.

---

Why this is better

1. Better performance for local announce-heavy logic:
   • tx validity-window scans now work on hashes directly.
2. Cleaner data model:
   • announce graph is lightweight and deterministic.
3. Clear separation of concerns:
   • transport payloads vs persisted consensus objects.
4. Explicit failure points:
   • missing tx body surfaces as precise errors instead of implicit assumptions.

---

Compatibility

This is a breaking storage-format change for announces.

• Old DB data that encoded announces with embedded signed tx bodies is incompatible.
• Resync is required after upgrading.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
ethexe/consensus/src/validator/subordinate.rs	78% smaller
ethexe/consensus/src/validator/initial.rs	75% smaller
ethexe/consensus/src/announces.rs	68% smaller
ethexe/network/src/db_sync/requests.rs	51% smaller
ethexe/compute/src/lib.rs	50% smaller
ethexe/common/src/consensus.rs	47% smaller
ethexe/consensus/src/tx_validation.rs	33% smaller
ethexe/consensus/src/connect/mod.rs	33% smaller
ethexe/consensus/src/validator/producer.rs	32% smaller
ethexe/network/src/db_sync/responses.rs	24% smaller
ethexe/db/src/migrations/v2.rs	19% smaller
ethexe/service/src/tests/mod.rs	19% smaller
ethexe/common/src/db.rs	18% smaller
ethexe/common/src/network.rs	11% smaller
ethexe/compute/src/compute.rs	9% smaller
ethexe/common/src/primitives.rs	5% smaller
ethexe/network/src/validator/topic.rs	1% smaller
ethexe/network/src/db_sync/mod.rs	1% smaller
ethexe/common/src/injected.rs	0% smaller
ethexe/common/src/mock.rs	0% smaller
ethexe/db/src/verifier.rs	0% smaller
ethexe/network/src/peer_score.rs	0% smaller
ethexe/service/src/fast_sync.rs	Unsupported file format

[ecol-master]

// just to remove requested changes

[ecol-master]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce440222d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ecol-master]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc73a634b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Validate loaded injected tx matches announce signature

This path now ignores the signature committed in AnnounceInjectedTransaction and resolves each entry only by tx_hash, so compute can execute a different signed envelope than the one referenced by the announce. Since injected transactions are stored by hash key and later writes overwrite earlier values, a subsequent write of the same payload hash with a different signature can change the recovered sender used during execution; that can alter state/promise results and make nodes depend on local write timing. Please verify the fetched transaction signature equals tx.signature() (or store/retrieve by the full announce tuple) before converting it to verified data.

Useful? React with 👍 / 👎.