feat(ethexe/ethereum): bump alloy to 1.8.3, add custom Eip1559Estimator for AlloyProvider#5259
Conversation
…tor` for `AlloyProvider`
Changed Files
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on upgrading the project's dependency on the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
ethexe/ethereum/src/lib.rs
Outdated
| .with_gas_estimation() | ||
| .with_eip1559_estimator(Eip1559Estimator::new( | ||
| |base_fee_per_gas: u128, rewards: &[Vec<u128>]| { | ||
| utils::eip1559_default_estimator(base_fee_per_gas, rewards).scaled_by_pct(15) |
There was a problem hiding this comment.
I'll add config
There was a problem hiding this comment.
Code Review
This pull request updates the alloy library to version 1.8 and switches the patched branch to better-gas-estimation across the workspace. It also introduces a custom EIP-1559 gas estimator in the Ethereum provider that applies a 15% safety margin to default estimates. The review feedback identifies an outdated TODO comment in Cargo.toml and suggests extracting the hardcoded gas scaling factor into a named constant for improved maintainability.
|
/gemini review This PR should fix validator commits on Ethereum Mainnet. We want to use medium gas +15% for validators commits and x3 blob fee when client uploads code. |
There was a problem hiding this comment.
Code Review
This pull request introduces configurable EIP-1559 fee increase percentages and blob gas multipliers across the ethexe service and CLI. It updates the alloy dependency to version 1.8.3 (branch better-gas-estimation) and implements a custom EIP-1559 estimator in the provider creation logic. Additionally, the basics test has been re-enabled. Feedback is provided regarding the hardcoded gas parameters in the tx command, which should instead utilize the newly introduced configuration options for consistency.
ref alloy-rs/alloy#3849
ref https://github.com/gear-tech/alloy/tree/better-gas-estimation