feat(ethexe): bump foundry toolchain, add configurable gas, use only EIP-7594 txs#5263
feat(ethexe): bump foundry toolchain, add configurable gas, use only EIP-7594 txs#5263StackOverflowExcept1on wants to merge 4 commits intomasterfrom
Conversation
Changed Files
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces configuration options for Ethereum transaction parameters and streamlines the transaction submission process by standardizing on EIP-7594. These changes improve the flexibility of the CLI and reduce technical debt in the router implementation. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new CLI options for EIP-1559 fee increase percentages and blob gas multipliers, and simplifies the Ethereum router logic by removing conditional sidecar handling for specific chain IDs. Additionally, a basic service test has been ignored due to RPC issues. Feedback was provided regarding the ignored test, noting that it creates a verification gap and should be accompanied by a tracking issue and a more detailed explanation for the ignore status.
| builder.sidecar_7594(SidecarBuilder::<SimpleCoder>::from_slice(code).build_7594()?) | ||
| }; | ||
| let builder = | ||
| builder.sidecar_7594(SidecarBuilder::<SimpleCoder>::from_slice(code).build_7594()?); |
There was a problem hiding this comment.
I also want to experiment with EIP-7594 txs here: @vara-eth/api (API is currently broken on testnet and we could backport wevm/viem#4022 to fix it). The thing is that Foundry updates quite slowly and I switched it to nightly so that we could use only one transaction type for blobs - EIP-7594.
Now we need to use the new version of Foundry (for local dev):