Skip to content

feat(ethexe): bump foundry toolchain, add configurable gas, use only EIP-7594 txs#5263

Open
StackOverflowExcept1on wants to merge 4 commits intomasterfrom
av/ethexe-cli-configurable
Open

feat(ethexe): bump foundry toolchain, add configurable gas, use only EIP-7594 txs#5263
StackOverflowExcept1on wants to merge 4 commits intomasterfrom
av/ethexe-cli-configurable

Conversation

@StackOverflowExcept1on
Copy link
Copy Markdown
Member

@StackOverflowExcept1on StackOverflowExcept1on commented Mar 28, 2026

Now we need to use the new version of Foundry (for local dev):

foundryup -i nightly-c07d504b4ae67754584f4e05ff0c547a43c50f7b

@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team D8-ethexe ethexe-related PR labels Mar 28, 2026
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com bot commented Mar 28, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  ethexe/ethereum/src/router/mod.rs  49% smaller
  .github/workflows/build.yml  0% smaller
  .github/workflows/check.yml  0% smaller
  ethexe/cli/src/commands/tx.rs Unsupported file format

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces configuration options for Ethereum transaction parameters and streamlines the transaction submission process by standardizing on EIP-7594. These changes improve the flexibility of the CLI and reduce technical debt in the router implementation.

Highlights

  • Configurable Ethereum Parameters: Added support for configurable EIP-1559 fee increase percentages and blob gas multipliers in the CLI, allowing for more flexible transaction handling.
  • EIP-7594 Standardization: Simplified the router transaction logic to exclusively use EIP-7594 transactions, removing legacy chain-specific workarounds.
  • Test Maintenance: Temporarily ignored the 'basics' test in the service module due to pending RPC fixes.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/build.yml
    • .github/workflows/check.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new CLI options for EIP-1559 fee increase percentages and blob gas multipliers, and simplifies the Ethereum router logic by removing conditional sidecar handling for specific chain IDs. Additionally, a basic service test has been ignored due to RPC issues. Feedback was provided regarding the ignored test, noting that it creates a verification gap and should be accompanied by a tracking issue and a more detailed explanation for the ignore status.

builder.sidecar_7594(SidecarBuilder::<SimpleCoder>::from_slice(code).build_7594()?)
};
let builder =
builder.sidecar_7594(SidecarBuilder::<SimpleCoder>::from_slice(code).build_7594()?);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want to experiment with EIP-7594 txs here: @vara-eth/api (API is currently broken on testnet and we could backport wevm/viem#4022 to fix it). The thing is that Foundry updates quite slowly and I switched it to nightly so that we could use only one transaction type for blobs - EIP-7594.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0-pleasereview PR is ready to be reviewed by the team D8-ethexe ethexe-related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant