Skip to content

Fix Toolbar initialization to prevent widget serialization crash in Solara #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Toolbar initialization to prevent widget serialization crash in Solara #2324

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dda54aa
Initial plan
Copilot Oct 30, 2025
206fe63
Fix Toolbar initialization for Solara compatibility
Copilot Oct 30, 2025
170fd18
Fix comment formatting in toolbar.py
giswqs Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions geemap/toolbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,11 @@ def __init__(
callback=self._toggle_callback,
reset=True,
)
self.main_tools = main_tools + ([self.toggle_widget] if extra_tools else [])
self.extra_tools = extra_tools
# Use hold_trait_notifications to avoid triggering widget serialization
# during initialization, which can cause issues in Solara and other environments
Copy link
Collaborator

@schwehr schwehr Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add . at the end of sentence.

Copy link
Member

@giswqs giswqs Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added .

with self.hold_trait_notifications():
self.main_tools = main_tools + ([self.toggle_widget] if extra_tools else [])
self.extra_tools = extra_tools
for widget in self.main_tools + self.extra_tools:
widget.callback_wrapper = lambda callback, value, tool: callback(
self.host_map, value, tool
Expand Down