Skip to content

Conversation

@Blankll
Copy link
Member

@Blankll Blankll commented Feb 16, 2025

fix: fix the frontend deployment issue

  • create si defined roles for ossdeployment to fix policy name conflicts issue
  • update schema validation to move required property of delete_force as optional
  • enable support to specify the access control of bucket

Refs: #36

@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.82%. Comparing base (93974f3) to head (cafc186).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/parser/bucketParser.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   86.67%   86.82%   +0.14%     
==========================================
  Files          47       48       +1     
  Lines         563      577      +14     
  Branches       85       88       +3     
==========================================
+ Hits          488      501      +13     
- Misses         56       57       +1     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blankll Blankll marked this pull request as ready for review February 16, 2025 14:05
@Blankll Blankll merged commit 01e0ad8 into master Feb 16, 2025
4 checks passed
@Blankll Blankll deleted the fix/oss-deployment branch February 16, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants