Skip to content

Conversation

@Blankll
Copy link
Member

@Blankll Blankll commented Apr 7, 2025

Refactor: standardize all ros id and ros resources name convention

Refs: #38

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (02ac9df) to head (a5d2c1a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/stack/rosStack/bucket.ts 83.33% 0 Missing and 1 partial ⚠️
src/stack/rosStack/function.ts 94.11% 0 Missing and 1 partial ⚠️
...sts/fixtures/deploy-fixtures/oneFcWithContainer.ts 75.00% 0 Missing and 1 partial ⚠️
tests/fixtures/deploy-fixtures/oneFcWithGpu.ts 75.00% 0 Missing and 1 partial ⚠️
tests/fixtures/deploy-fixtures/oneFcWithNas.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   86.88%   87.36%   +0.47%     
==========================================
  Files          50       62      +12     
  Lines         717      744      +27     
  Branches      113      113              
==========================================
+ Hits          623      650      +27     
  Misses         70       70              
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Blankll Blankll marked this pull request as ready for review April 8, 2025 14:21
@Blankll Blankll merged commit d6285bf into master Apr 8, 2025
4 checks passed
@Blankll Blankll deleted the refactor/standlize-id branch April 8, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants