chore: Centralize all DEBUG checks in debugLog #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
|
Ugh I was sure I'd already fixed this... twice now. Can you fix conflicts, then I'll merge |
max-stytch
force-pushed
the
max/chore-remove-debug-checks
branch
from
71c18bd to
d829b50
Compare
|
@geelen Should be good now. I had to add back in a stub test to make vitest happy - https://github.com/geelen/mcp-remote/actions/runs/16156064484/job/45598668504 Figured a stub test would be better than ripping out tests entirely, though there are currently no tests in this package. I am not sure why other jobs haven't failed previously. |
geelen
force-pushed
the
max/chore-remove-debug-checks
branch
from
d829b50 to
2a250fa
Compare
geelen
force-pushed
the
max/chore-remove-debug-checks
branch
from
2a250fa to
c033c67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny QoL change -
debugLogalready checks theDEBUGglobal for us. There's no need to check it before invokingdebugLog.