feat(auth-timeout): make callback timeout configurable #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geelen
force-pushed
the
petek/feat/auth-timeout
branch
from
4c2dc3f to
f5da358
Compare
commit: |
- Consolidated duplicate import statements - Removed duplicate parseCommandLineArgs test suite (lines 781-880) - Integrated auth timeout tests into original comprehensive test suite - Preserved setupOAuthCallbackServerWithLongPoll tests as they were new - All 62 tests still passing with complete coverage maintained Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-904c01b3-2429-402e-a289-5c1b1a441b23
geelen
force-pushed
the
petek/feat/auth-timeout
branch
from
f5da358 to
faf10b6
Compare
|
Thank you for this and sorry it took me so long to get to it! |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some auth servers can be very slow (in our case, running on lambdas). The callback can sometimes take longer than 30 seconds. This adds a flag to make that configurable.
Closes #122