Do not sync owner/group for FAT filesystems #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can potentially cause rsync error messages, especially if the filesystem is already mounted with a uid= option (which will not be copied to the destination mount, leading to different owners and thus rsync trying and failing to fix the owner).
matthijskooijman
force-pushed
the
no-sync-attrs-for-fat
branch
from
fd5d6ce to
1567f84
Compare
|
Prompted by @framps' suggestion of adding more comments inline, I've added clarification of the FAT-specific rsync options in a comment, and also restuctured the code to not have two complete lists of rsync options (one for FAT and one for the rest), which are hard to read and prone to getting out of sync. Now, for FAT filesystems, the I have not been able to test this yet, so I'm marking this as draft until I did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can potentially cause rsync error messages, especially if the filesystem is already mounted with a uid= option (which will not be copied to the destination mount, leading to different owners and thus rsync trying and failing to fix the owner).
This commit was previously submitted as part of billw2#140 (but really unrelated to the core of that PR, so I'm submitting it separately here now) and have been in use in my project since that PR was submitted two years ago. Now I've just rebased and reviewed them, the changes still applied without issue.