Skip to content

Allow Filament v4 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Allow Filament v4 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0ec428
Allow Filament v4
gehrisandro Jun 11, 2025
9f7041b
Upgrade to Filament v4
gehrisandro Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
],
"require": {
"php": "^8.1",
"filament/forms": "^3.0",
"filament/forms": "^4.0",
"spatie/laravel-package-tools": "^1.15.0",
"illuminate/contracts": "^10.0|^11.0|^12.0"
},
"require-dev": {
"nunomaduro/collision": "^7.9",
"nunomaduro/collision": "^v8.8.0",
"orchestra/testbench": "^8.0|^9.0|^10.0",
"pestphp/pest": "^2.0|^3.7",
"pestphp/pest-plugin-arch": "^2.0|^3.0",
Expand Down
32 changes: 16 additions & 16 deletions src/SelectTree.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@

namespace CodeWithDennis\FilamentSelectTree;

use Filament\Schemas\Components\Contracts\HasAffixActions;
use Filament\Schemas\Components\Concerns\CanBeDisabled;
use Filament\Schemas\Components\Concerns\HasActions;
use Filament\Schemas\Schema;
use Filament\Actions\Action;
use InvalidArgumentException;
use Closure;
use Exception;
use Filament\Forms\ComponentContainer;
use Filament\Forms\Components\Actions\Action;
use Filament\Forms\Components\Concerns\CanBeDisabled;
use Filament\Forms\Components\Concerns\CanBeSearchable;
use Filament\Forms\Components\Concerns\HasActions;
use Filament\Forms\Components\Concerns\HasAffixes;
use Filament\Forms\Components\Concerns\HasPivotData;
use Filament\Forms\Components\Concerns\HasPlaceholder;
use Filament\Forms\Components\Contracts\HasAffixActions;
use Filament\Forms\Components\Field;
use Filament\Forms\Form;
use Filament\Support\Facades\FilamentIcon;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Illuminate\Database\Eloquent\Relations\BelongsToMany;
Expand Down Expand Up @@ -130,12 +130,12 @@ protected function setUp(): void
}
});

$this->createOptionUsing(static function (SelectTree $component, array $data, Form $form) {
$this->createOptionUsing(static function (SelectTree $component, array $data, Schema $schema) {
$record = $component->getRelationship()->getRelated();
$record->fill($data);
$record->save();

$form->model($record)->saveRelationships();
$schema->model($record)->saveRelationships();

return $component->getCustomKey($record);
});
Expand Down Expand Up @@ -310,7 +310,7 @@ public function prepend(Closure|array|null $prepend = null): static
if (is_array($this->prepend) && isset($this->prepend['name'], $this->prepend['value'])) {
$this->prepend['value'] = (string) $this->prepend['value'];
} else {
throw new \InvalidArgumentException('The provided prepend value must be an array with "name" and "value" keys.');
throw new InvalidArgumentException('The provided prepend value must be an array with "name" and "value" keys.');
}

return $this;
Expand Down Expand Up @@ -510,9 +510,9 @@ public function getHiddenOptions(): array
return $this->evaluate($this->hiddenOptions);
}

public function getCreateOptionActionForm(Form $form): array|Form|null
public function getCreateOptionActionForm(Schema $schema): array|Schema|null
{
return $this->evaluate($this->createOptionActionForm, ['form' => $form]);
return $this->evaluate($this->createOptionActionForm, ['form' => $schema]);
}

public function hasCreateOptionActionFormSchema(): bool
Expand Down Expand Up @@ -560,19 +560,19 @@ public function getCreateOptionAction(): ?Action
}

$action = Action::make($this->getCreateOptionActionName())
->form(function (SelectTree $component, Form $form): array|Form|null {
return $component->getCreateOptionActionForm($form->model(
->schema(function (SelectTree $component, Schema $schema): array|Schema|null {
return $component->getCreateOptionActionForm($schema->model(
$component->getRelationship() ? $component->getRelationship()->getModel()::class : null,
));
})
->action(static function (Action $action, array $arguments, SelectTree $component, array $data, ComponentContainer $form) {
->action(static function (Action $action, array $arguments, SelectTree $component, array $data, Schema $schema) {
if (! $component->getCreateOptionUsing()) {
throw new Exception("Select field [{$component->getStatePath()}] must have a [createOptionUsing()] closure set.");
}

$createdOptionKey = $component->evaluate($component->getCreateOptionUsing(), [
'data' => $data,
'form' => $form,
'form' => $schema,
]);

$state = $component->getMultiple()
Expand All @@ -591,7 +591,7 @@ public function getCreateOptionAction(): ?Action

$action->callAfter();

$form->fill();
$schema->fill();

$action->halt();
})
Expand Down
15 changes: 5 additions & 10 deletions tests/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,10 @@
use BladeUI\Icons\BladeIconsServiceProvider;
use CodeWithDennis\FilamentSelectTree\FilamentSelectTreeServiceProvider;
use Filament\Actions\ActionsServiceProvider;
use Filament\FilamentServiceProvider;
use Filament\Forms\FormsServiceProvider;
use Filament\Infolists\InfolistsServiceProvider;
use Filament\Notifications\NotificationsServiceProvider;
use Filament\SpatieLaravelSettingsPluginServiceProvider;
use Filament\SpatieLaravelTranslatablePluginServiceProvider;
use Filament\Support\SupportServiceProvider;
use Filament\Tables\TablesServiceProvider;
use Filament\Widgets\WidgetsServiceProvider;
use Illuminate\Database\Eloquent\Factories\Factory;
use Livewire\LivewireServiceProvider;
use Orchestra\Testbench\TestCase as Orchestra;
Expand All @@ -38,16 +33,16 @@ protected function getPackageProviders($app)
BladeCaptureDirectiveServiceProvider::class,
BladeHeroiconsServiceProvider::class,
BladeIconsServiceProvider::class,
FilamentServiceProvider::class,
// FilamentServiceProvider::class,
FormsServiceProvider::class,
InfolistsServiceProvider::class,
LivewireServiceProvider::class,
NotificationsServiceProvider::class,
SpatieLaravelSettingsPluginServiceProvider::class,
SpatieLaravelTranslatablePluginServiceProvider::class,
// SpatieLaravelSettingsPluginServiceProvider::class,
// SpatieLaravelTranslatablePluginServiceProvider::class,
SupportServiceProvider::class,
TablesServiceProvider::class,
WidgetsServiceProvider::class,
// TablesServiceProvider::class,
// WidgetsServiceProvider::class,
FilamentSelectTreeServiceProvider::class,
];
}
Expand Down