Add a for_ operator
#887
Add a for_ operator
#887
Conversation
| # SPDX-FileCopyrightText: Copyright Gel Data Inc. and the contributors. | ||
|
|
||
|
|
||
| """Query building constructs""" |
There was a problem hiding this comment.
Any reason for this to be public? If not, move this into _internal._qbmodel._abstract
There was a problem hiding this comment.
I kind of felt that language features like this ought to be accessible somewhere other than the mildly-hacky std. Not sure if gel.qb is the best for that, though anyway.
I don't really mind dropping it if you think it's not worth exposing
gel/qb.py
Outdated
| _X = TypeVar("_X", bound=_abstract.GelType) | ||
|
|
||
|
|
||
| def for_in(iter: type[_T], body: Callable[[type[_T]], type[_X]]) -> type[_X]: |
There was a problem hiding this comment.
We had a bikeshed about naming this and IIRC the conclusion was that for_ was acceptable (we already have and_ and if_ etc).
|
|
||
| def process(self, mod: IntrospectedModule) -> None: | ||
| if str(self.canonical_modpath) == 'std': | ||
| self.write("# Re-export top-level query-builder functions") |
There was a problem hiding this comment.
You must self.py_file.export(name) and self.py_file.update_globals(names) here (I'd also move this block into prepare_namespace since it already has std-specific wrangling.
There was a problem hiding this comment.
What does that accomplish here?
There was a problem hiding this comment.
In addition to emitting the explicit export?
dnwpark
left a comment
dnwpark
left a comment
There was a problem hiding this comment.
Looks good, but will wait on those other pydantic comments from elvis
| "PIE", # flake8-pie | ||
| "PL", # pylint | ||
| "PYI", # flake8-pyi | ||
| "Q", # flake8-quotes |
| return (self.iter_expr, self.body) | ||
|
|
||
| def _edgeql(self, ctx: ScopeContext) -> str: | ||
| ctx.bind(self.var) |
There was a problem hiding this comment.
Why doesn't this get bound in for_?
| iter_expr = _qb.edgeql_qb_expr(iterator) | ||
| scope = _qb.Scope() | ||
| var = _qb.Variable(type_=iter_expr.type, scope=scope) | ||
| body_ = body(_qb.AnnotatedVar(iterator.__gel_origin__, var)) # type: ignore [arg-type, attr-defined] |
There was a problem hiding this comment.
iterator.gel_origin might be a pure type[GelModel] if you just passed an object type class, e.g for_(User, ...), so you need to check iterator is really a BaseAlias
msullivan
force-pushed
the
for-loops
branch
3 times, most recently
from
70098bc to
10b7da6
Compare
Following Elvis's original branch, I added it to a
gel.qbmodule.I also, on Elvis's suggestion, modified
stdto re-export everythingfrom
gel.qb.I renamed his
foreachtofor_to better match EdgeQL.Fixes #729.