Allow running tests with geltest #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
requested review from
1st1,
aljazerzen,
dnwpark,
fantix and
msullivan
msullivan
reviewed
Sep 2, 2025
msullivan
reviewed
Sep 2, 2025
msullivan
approved these changes
Sep 3, 2025
fantix
approved these changes
Sep 3, 2025
elprans
force-pushed
the
geltest
branch
2 times, most recently
from
d9ef4fe to
e13fd3c
Compare
The vast majority of model reflection is std, and though in a specific
schema reflection we can avoid running codegen if things did not change,
that does not help across multiple branches.
This makes it possible to
1) generate `std` separately from user/extension schema (via
`--std-only`), and
2) import a std reflection generated earlier with
`--source-std-from=<path>`, specifying the sourcing method
woth `--source-std-method={copy|reexport}`.
…self The new `gel._internal._server` is a collection of `Instance` implementations to manage server lifecycle. This is primarily needed for tests.
`geltest` [1] is `edb test` extracted out of Gel server codebase and generalized to run any `unittest`-based suite. Notable changes here: 1. `_testbase` moved to `_internal._testbase` and broken down along major case types (base, models, third-party ORM); 2. Test cases that involve model generation now reuse `std` reflection for better `mypy` cache utilization. 3. Test models are now reflected into (.gitignored) `tests/models` and relative imports in tests now work consistently (so instead of `from models.orm import Foo` write `from .models.orm import Foo` and have your editor LSP pick that up. This obviates the need to run `tools/gen_models.py` (which I will remove in a subsequent commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsolationLevela proper enum