Fix ORDER BY in complex situations #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make IteratorStmt bind with WITH instead of FOR when self_ref_must_bind. This gives us a distinct name for the binding but still relies on the Select or whatever to do the actual binding, which makes ORDER BY work properly. (Previously ORDER BY wouldn't work in these cases because it was inside a FOR.) Fixes #893.
elprans
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make IteratorStmt bind with WITH instead of FOR when
self_ref_must_bind. This gives us a distinct name for the binding
but still relies on the Select or whatever to do the actual binding,
which makes ORDER BY work properly.
(Previously ORDER BY wouldn't work in these cases because it was
inside a FOR.)
Fixes #893.