pg_ext: fix to_regclass(), ::regclass and pg_settings#8511
Merged
Conversation
fantix
force-pushed
the
sql-to_regclass
branch
2 times, most recently
from
2b58bbd to
aa51219
Compare
aljazerzen
approved these changes
Mar 28, 2025
Contributor
aljazerzen
left a comment
aljazerzen
left a comment
There was a problem hiding this comment.
Kudos fantix! Was this translated from postgres's C implementation?
Member
Author
|
Yeah, it's from C. Unfortunately, they don't have SQL interfaces. |
elprans
approved these changes
Mar 28, 2025
Member
elprans
left a comment
elprans
left a comment
There was a problem hiding this comment.
LGTM, but please add some tests before merging.
Member
Author
|
Right, I noticed that in-transaction settings are not applied during writing tests, will also have to fix that. |
Contributor
|
FYI: some of our sql test classes use transactions and some don't, that might be interfering. (I'm not really sure what you mean fantix, so I don't know if this is relevant) |
msullivan
reviewed
Mar 31, 2025
This was referenced Apr 2, 2025
fantix
commented
Apr 4, 2025
| CREATE CONSTRAINT TRIGGER _edgecon_state_local_reset | ||
| AFTER INSERT ON _edgecon_state | ||
| DEFERRABLE INITIALLY DEFERRED | ||
| FOR EACH ROW EXECUTE FUNCTION edgedb._clear_fe_local_sql_settings(); |
Member
Author
There was a problem hiding this comment.
Ah, this will be tricky for edb.pgsql.patches to patch up, let me think of a workaround
msullivan
added
backported-6.x
fantix
added a commit
that referenced
this pull request
Apr 7, 2025
* Implement frontend-aware `pg_settings` and `pg_show_all_settings` * Implement `current_schemas()` function in the backend * Fix SQL implementation of `to_regclass()` and typecasting * Fix SHOW ALL command * Re-implement SHOW command with backend SQL
fantix
added a commit
that referenced
this pull request
Apr 7, 2025
* Implement frontend-aware `pg_settings` and `pg_show_all_settings` * Implement `current_schemas()` function in the backend * Fix SQL implementation of `to_regclass()` and typecasting * Fix SHOW ALL command * Re-implement SHOW command with backend SQL
msullivan
added
backported-6.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8508
Refs #8488
pg_settingssplit_identifier_string()current_schemas()function in the backendto_regclass()