Skip to content

OPEN-85: General API refactoring to ensure consistent design and naming across all modules#21

Merged
tobias-schwerdtfeger merged 5 commits intomain-rustffifrom
feature/open-85-api-refinement
Dec 9, 2025
Merged

OPEN-85: General API refactoring to ensure consistent design and naming across all modules#21
tobias-schwerdtfeger merged 5 commits intomain-rustffifrom
feature/open-85-api-refinement

Conversation

@tobias-schwerdtfeger
Copy link
Member

This includes the following changes:

  • Introduced code review templates to standardize review practices.
  • Provided architectural guidelines to ensure consistency in implementation.
  • Added constant time equals for secure key materials.
  • Overall refactoring and alignments of the API.

@tobias-schwerdtfeger tobias-schwerdtfeger self-assigned this Dec 8, 2025
@tobias-schwerdtfeger tobias-schwerdtfeger changed the title Add licenses and review templates for consistency OPEN-85: Add licenses and review templates for consistency Dec 8, 2025
@tobias-schwerdtfeger tobias-schwerdtfeger changed the title OPEN-85: Add licenses and review templates for consistency OPEN-85: General API refactoring to ensure consistent design and naming across all modules Dec 8, 2025
…ut the codebase

- Implement `Default` trait for `WriterScope`
- Replace custom range logic with use of the `contains` method
- Refactor `write_multi_byte` to delegate logic to `write_base128`
- Add unit tests for `write_base128`, sequence counter accessors, and identifier verification
- Refactor APDU parsing to eliminate redundant fields and improve readability
- Introduce `MlkemPrivateKey` with support for export/import and enhance multi-level key handling
- Optimize digest, ECDH, AES cipher, and ASN.1 decoder functionality
- Add new tests for utility functions and generalized operations
@tobias-schwerdtfeger tobias-schwerdtfeger merged commit f03fae3 into main-rustffi Dec 9, 2025
3 checks passed
@tobias-schwerdtfeger tobias-schwerdtfeger deleted the feature/open-85-api-refinement branch December 9, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants