OPEN-79: Support for zeroizing Asn1Encoder/WriterScope via VecOfU8#55
Open
simon-void wants to merge 2 commits intomainfrom
Open
OPEN-79: Support for zeroizing Asn1Encoder/WriterScope via VecOfU8#55simon-void wants to merge 2 commits intomainfrom
simon-void wants to merge 2 commits intomainfrom
Conversation
| } | ||
| } | ||
|
|
||
| let mut apdu = Vec::new(); |
Member
There was a problem hiding this comment.
Needs to be the same type of VecOfU8 somehow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support for zeroizing datatype VecOfU8.
Please check during review if throughout the code the appropriate variant of VecOfU8 is used!
Zeroizing is more secure but takes additional time (because its memory will be overriden by 0s on Drop).
NonZeroizing is less secure but faster.
Changes
Breaking Changes
Checklist
docs/,README.md) if neededReleaseNotes.md) if user-facing change