Skip to content

Stufe 5: Use CLOSE_SLICING_FOR_VALIDATION #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexzautke wants to merge 26 commits into from
Closed

Stufe 5: Use CLOSE_SLICING_FOR_VALIDATION #966

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
d6dbc23
Use CLOSE_SLICING_FOR_VALIDATION
alexzautke Dec 25, 2025
27c38ce
Update Firely.Terminal action to alpha version
alexzautke Dec 25, 2025
b0e5bac
Update Firely.Terminal action version to alpha2
alexzautke Dec 25, 2025
97402b6
Update Firely terminal pipeline version to alpha3
alexzautke Dec 25, 2025
18226fe
Update Firely terminal pipeline version to alpha4
alexzautke Dec 25, 2025
b58ef63
Update Firely.Terminal action to v0.7.25-alpha5
alexzautke Dec 25, 2025
b38df43
Fix Appendektomie example
alexzautke Dec 25, 2025
2f7a5e4
Swap LOINC -> KDL Composition.type
alexzautke Dec 25, 2025
37f7b1e
ISiKBlutdruckSystemischArteriell: Add explicit LOINC slice
alexzautke Dec 25, 2025
5995178
Fix cardinality
alexzautke Dec 25, 2025
c6b9e31
Update advisor.json
alexzautke Dec 25, 2025
43528c1
Add validation filters for BundleExampleIntensivstation
alexzautke Dec 26, 2025
7d4b2d2
fix: correct formatting in validation filters for BundleExampleIntens…
patrick-werner Jan 23, 2026
3ff1be3
auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)
patrick-werner Jan 23, 2026
0fd146f
Merge branch 'main-stufe-5' into alexzautke-patch-2
f-peverali Feb 11, 2026
d142efc
Merge branch 'main-stufe-5' into alexzautke-patch-2
f-peverali Feb 12, 2026
9c3d218
Update Firely terminal pipeline to version 0.8.3
alexzautke Mar 13, 2026
a673aaf
Add validation entries for gender and birthDate extensions
alexzautke Mar 13, 2026
56321cd
Merge branch 'main-stufe-5' into alexzautke-patch-2
alexzautke Mar 13, 2026
8a8ac00
Merge remote-tracking branch 'origin/main-stufe-5' into alexzautke-pa…
patrick-werner Mar 18, 2026
25ec40a
commit sushi results
patrick-werner Mar 18, 2026
fff232b
chore: remove deactivated add & commit step from IG publisher workflow
patrick-werner Mar 18, 2026
6202afa
feat: add auto-commit step for generated FHIR files in CI workflow
patrick-werner Mar 18, 2026
0d1ae19
removed ig publisher piplines for stufe-5
patrick-werner Mar 18, 2026
3f1462e
fix: add validation entries for SDC extensions in FHIR resources
patrick-werner Mar 18, 2026
fec170c
fix: syntax
patrick-werner Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
if: github.event_name != 'pull_request'

- name: Firely.Terminal (GitHub Actions)
uses: FirelyTeam/firely-terminal-pipeline@v0.7.24
uses: FirelyTeam/firely-terminal-pipeline@v0.7.25-alpha5
with:
PATH_TO_CONFORMANCE_RESOURCES: Resources/fsh-generated/resources/
DOTNET_VALIDATION_ENABLED: false
Expand All @@ -70,6 +70,7 @@ jobs:
SIMPLIFIER_PASSWORD: ${{ secrets.SIMPLIFIER_PASSWORD }}
SUSHI_ENABLED: true
TERMINOLOGY_SERVICE_BFARM_ENABLED: true
CLOSE_SLICING_FOR_VALIDATION: true
SUSHI_OPTIONS: Resources/
EXPECTED_FAILS: VALIDATION_CONFORMANCE_JAVA VALIDATION_CONFORMANCE_DOTNET

Expand All @@ -89,6 +90,10 @@ jobs:
include: errors
filters: |
# Struktur: fileName|messageId|detailsWildcard|location
Bundle-BundleExampleIntensivstation.json|Validation_VAL_Profile_NotSlice||Bundle.entry[3]
Bundle-BundleExampleIntensivstation.json|Validation_VAL_Profile_NotSlice||Bundle.entry[4]
Bundle-BundleExampleIntensivstation.json|Validation_VAL_Profile_NotSlice||Bundle.entry[5]

- name: Validate Resource Status
uses: patrick-werner/fhir-resource-status-check@1.2.0
with:
Expand Down
12 changes: 6 additions & 6 deletions Resources/fsh-generated/resources/Bundle-BundleExampleIntensivstation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,8 @@
"code": {
"coding": [
{
"system": "http://loinc.org",
"code": "8480-6"
"code": "8480-6",
"system": "http://loinc.org"
}
]
},
Expand All @@ -292,8 +292,8 @@
"code": {
"coding": [
{
"system": "http://loinc.org",
"code": "8462-4"
"code": "8462-4",
"system": "http://loinc.org"
}
]
},
Expand All @@ -308,8 +308,8 @@
"code": {
"coding": [
{
"system": "http://loinc.org",
"code": "8478-0"
"code": "8478-0",
"system": "http://loinc.org"
}
]
},
Expand Down
4 changes: 2 additions & 2 deletions Resources/fsh-generated/resources/Bundle-ISiKBundle-Example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"type": {
"coding": [
{
"code": "55112-7",
"system": "http://loinc.org"
"code": "AD010112",
"system": "http://dvmd.de/fhir/CodeSystem/kdl"
}
],
"text": "Kurzbericht"
Expand Down
4 changes: 2 additions & 2 deletions Resources/fsh-generated/resources/Composition-CompositionExampleBlutdruck.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"type": {
"coding": [
{
"code": "55112-7",
"system": "http://loinc.org"
"code": "AD010112",
"system": "http://dvmd.de/fhir/CodeSystem/kdl"
}
],
"text": "Kurzbericht"
Expand Down
12 changes: 6 additions & 6 deletions Resources/fsh-generated/resources/Observation-ISiKBlutdruckSystemischArteriellExample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"version": "http://snomed.info/sct/11000274103"
},
{
"system": "http://loinc.org",
"code": "8480-6"
"code": "8480-6",
"system": "http://loinc.org"
}
]
},
Expand All @@ -80,8 +80,8 @@
"version": "http://snomed.info/sct/11000274103"
},
{
"system": "http://loinc.org",
"code": "8462-4"
"code": "8462-4",
"system": "http://loinc.org"
}
]
},
Expand All @@ -107,8 +107,8 @@
"version": "http://snomed.info/sct/11000274103"
},
{
"system": "http://loinc.org",
"code": "8478-0"
"code": "8478-0",
"system": "http://loinc.org"
}
]
},
Expand Down
12 changes: 6 additions & 6 deletions ...urces/fsh-generated/resources/Observation-ISiKBlutdruckSystemischArteriellMaxExample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"version": "http://snomed.info/sct/11000274103"
},
{
"system": "http://loinc.org",
"code": "8480-6"
"code": "8480-6",
"system": "http://loinc.org"
}
]
},
Expand Down Expand Up @@ -91,8 +91,8 @@
"version": "http://snomed.info/sct/11000274103"
},
{
"system": "http://loinc.org",
"code": "8462-4"
"code": "8462-4",
"system": "http://loinc.org"
}
]
},
Expand Down Expand Up @@ -129,8 +129,8 @@
"version": "http://snomed.info/sct/11000274103"
},
{
"system": "http://loinc.org",
"code": "8478-0"
"code": "8478-0",
"system": "http://loinc.org"
}
]
},
Expand Down
8 changes: 4 additions & 4 deletions ...urces/fsh-generated/resources/Observation-ISiKBlutdruckSystemischArteriellMinExample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
"code": {
"coding": [
{
"system": "http://loinc.org",
"code": "8480-6"
"code": "8480-6",
"system": "http://loinc.org"
}
]
},
Expand All @@ -46,8 +46,8 @@
"code": {
"coding": [
{
"system": "http://loinc.org",
"code": "8462-4"
"code": "8462-4",
"system": "http://loinc.org"
}
]
},
Expand Down
5 changes: 1 addition & 4 deletions Resources/fsh-generated/resources/Procedure-Appendektomie.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,9 @@
"display": "Excision of appendix (procedure)"
},
{
"version": "2020",
"code": "5-470",
"system": "http://fhir.de/CodeSystem/bfarm/ops",
"display": "Appendektomie"
},
{
"display": "Appendektomie",
"version": "2024"
}
],
Expand Down
2 changes: 1 addition & 1 deletion Resources/fsh-generated/resources/StructureDefinition-ISiKAMTSBewertung.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
}
],
"ordered": false,
"rules": "open"
"rules": "closed"
},
"short": "Zeitpunkt oder Zeitraum der Beurteilung",
"comment": "Begründung des Must-Support-Support-Flag (MS): Die Angabe des Zeitpunkts oder Zeitraums ist essentiell für die Nachvollziehbarkeit.\n\n Hintergrund: Das MS wurde im Rahmen der Ausarbeitung zur Stufe 4 des ISiK Moduls Medikation hinzugefügt und mit den Stakeholdern abgestimmt. ",
Expand Down
2 changes: 1 addition & 1 deletion Resources/fsh-generated/resources/StructureDefinition-ISiKAbrechnungsfall.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"path": "$this"
}
],
"rules": "open"
"rules": "closed"
},
"short": "Eindeutiger Identifier",
"comment": "Über die mit MS gekennzeichneten Slices hinaus können weitere Identifier vorkommen, ohne, dass eine ISiK Inkompatibilität besteht. Verarbeitet werden müssen aber nur die folgenden Slices.",
Expand Down
8 changes: 4 additions & 4 deletions Resources/fsh-generated/resources/StructureDefinition-ISiKAllergieUnvertraeglichkeit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
"path": "system"
}
],
"rules": "open"
"rules": "closed"
},
"min": 1,
"mustSupport": true
Expand Down Expand Up @@ -261,7 +261,7 @@
}
],
"ordered": false,
"rules": "open"
"rules": "closed"
},
"short": "Beginn-Zeitpunkt",
"comment": "**Begründung MS:** Der dokumentierte Beginn unterstützt die medizinische Bewertung, ob eine Allergie aktuell relevant ist, und wird in CapabilityStatements als Suchparameter gefordert.",
Expand Down Expand Up @@ -419,7 +419,7 @@
"path": "system"
}
],
"rules": "open"
"rules": "closed"
},
"mustSupport": true
},
Expand Down Expand Up @@ -466,7 +466,7 @@
"path": "system"
}
],
"rules": "open"
"rules": "closed"
},
"mustSupport": true
},
Expand Down
4 changes: 2 additions & 2 deletions Resources/fsh-generated/resources/StructureDefinition-ISiKAngehoeriger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"path": "$this"
}
],
"rules": "open"
"rules": "closed"
},
"short": "Offizieller Name der angehörigen Person",
"comment": "Aufgrund der primären Nutzung von Angehörigen-Informationen im ISiK-Kontext als Brief- und Rechnungsempfänger, \n ist die Angabe des offiziellen Namens relevant.\n Wenn kein Name vorliegt, MUSS die [data-absent-reason-Extension](https://www.hl7.org/fhir/R4/extension-data-absent-reason.html) eingesetzt werden. \n **Weitere Hinweise:** siehe [Deutsche Basisprofile](https://simplifier.net/guide/leitfaden-de-basis-r4/ig-markdown-Ressourcen-Patient?version=current#ig-markdown-Ressourcen-Patient-Name)",
Expand Down Expand Up @@ -176,7 +176,7 @@
"path": "$this"
}
],
"rules": "open"
"rules": "closed"
},
"short": "Offizielle Adresse der angehörigen Person",
"comment": "In order to differentiate between post box addresses and physical addresses, street names and house numbers, and to add city district names, vendors can opt to support the extensions as suggested in the German Address Base Profile http://fhir.de/StructureDefinition/address-de-basis.\r\nSuch differentiations are however not required within the scope of this specification.",
Expand Down
2 changes: 1 addition & 1 deletion Resources/fsh-generated/resources/StructureDefinition-ISiKBerichtBundle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"path": "resource"
}
],
"rules": "open"
"rules": "closed"
},
"short": "Eintrag pro Ressource",
"comment": "**Begründung MS:** Alle im Rahmen des Berichtes relevanten Informationen müssen hier referenziert werden.",
Expand Down
4 changes: 2 additions & 2 deletions Resources/fsh-generated/resources/StructureDefinition-ISiKBerichtSubSysteme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
"path": "$this"
}
],
"rules": "open"
"rules": "closed"
},
"mustSupport": true
},
Expand Down Expand Up @@ -174,7 +174,7 @@
"path": "$this"
}
],
"rules": "open"
"rules": "closed"
},
"mustSupport": true
},
Expand Down
42 changes: 39 additions & 3 deletions Resources/fsh-generated/resources/StructureDefinition-ISiKBlutdruckSystemischArteriell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,11 @@
"path": "$this"
}
],
"rules": "open"
"rules": "closed"
},
"short": "Coding",
"comment": "Motivation MS: Semantische Kodierung",
"min": 1,
"mustSupport": true
},
{
Expand All @@ -244,6 +245,17 @@
"system": "http://snomed.info/sct"
}
},
{
"id": "Observation.component:SystolicBP.code.coding:LOINC",
"path": "Observation.component.code.coding",
"sliceName": "LOINC",
"min": 1,

@f-peverali f-peverali Feb 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: i do not get it

@patrick-werner patrick-werner Mar 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bislang wurde loinc nur per pattern auf .code in den components erzwungen.
Da wir in der CI Pipeline alle slicings auf closed stellen, um examples zu finden die außerhalb unserer slices validieren, aber eigentlich invalide sind müssen wir hier ein Slice einführen.
Sonst würde unsere Instanzen nicht mehr validieren, der Loinc code wäre korrekt, aber es gäbe keinen matching slice

Inhaltich keine Änderung, Code im slice ist identisch zum pattern

"max": "1",
"patternCoding": {
"code": "8480-6",
"system": "http://loinc.org"
}
},
{
"id": "Observation.component:SystolicBP.value[x]",
"path": "Observation.component.value[x]",
Expand Down Expand Up @@ -322,10 +334,11 @@
"path": "$this"
}
],
"rules": "open"
"rules": "closed"
},
"short": "Coding",
"comment": "Motivation MS: Semantische Kodierung",
"min": 1,
"mustSupport": true
},
{
Expand All @@ -350,6 +363,17 @@
"system": "http://snomed.info/sct"
}
},
{
"id": "Observation.component:DiastolicBP.code.coding:LOINC",
"path": "Observation.component.code.coding",
"sliceName": "LOINC",
"min": 1,
"max": "1",
"patternCoding": {
"code": "8462-4",
"system": "http://loinc.org"
}
},
{
"id": "Observation.component:DiastolicBP.value[x]",
"path": "Observation.component.value[x]",
Expand Down Expand Up @@ -430,10 +454,11 @@
"path": "$this"
}
],
"rules": "open"
"rules": "closed"
},
"short": "Coding",
"comment": "Motivation MS: Semantische Kodierung",
"min": 1,
"mustSupport": true
},
{
Expand All @@ -458,6 +483,17 @@
"system": "http://snomed.info/sct"
}
},
{
"id": "Observation.component:meanBP.code.coding:LOINC",
"path": "Observation.component.code.coding",
"sliceName": "LOINC",
"min": 1,
"max": "1",
"patternCoding": {
"code": "8478-0",
"system": "http://loinc.org"
}
},
{
"id": "Observation.component:meanBP.value[x]",
"path": "Observation.component.value[x]",
Expand Down
Loading