fix: use Map to store line number mappings in the MCP server#91
Merged
fix: use Map to store line number mappings in the MCP server#91
Conversation
capachino
requested review from
QuanZhang-William,
evanotero,
heltonduarte,
pedrour and
shrishabh
as code owners
|
🤖 Hi @capachino, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
heltonduarte
approved these changes
Oct 15, 2025
CallumHYoung
pushed a commit
to CallumHYoung/security
that referenced
this pull request
Oct 17, 2025
CallumHYoung
pushed a commit
to CallumHYoung/security
that referenced
this pull request
Oct 20, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request refactors the findLineNumbers function to use a Map instead of an object for storing line numbers. The changes are straightforward and improve the code's clarity and performance. The path traversal check remains effective.
🔍 General Feedback
- The code quality is good, and the change is well-contained.
- No security vulnerabilities were identified in this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90