-
Notifications
You must be signed in to change notification settings - Fork 18
fix(chat): update WORKSPACE-Context.md with Chat-specific formatting instructions #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kamladi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds helpful Chat-specific formatting guidelines to the workspace context document. However, it also introduces widespread formatting changes that reduce the document's readability and consistency by flattening lists into paragraphs. The new Chat Guidelines section contains a couple of small but important errors regarding the syntax for italics and code blocks. My review includes suggestions to fix these errors and to revert the formatting of lists to improve clarity.
c39eb82 to
da5210e
Compare
Partially addresses gemini-cli-extensions#58 (Chat formatting task). Testing: - Manual test: LLM converts `**bold**` and `__bold__` to `*bold* ` - Manual test: LLM converts `*italic*` to `_italic_` - Manual test: LLM converts `[text](url)` to `<url|text>` - Manual test: LLM flattens nested list items, but prefixes the list items with dashes to indicate depth (e.g., "- parent", "- -- child", "- --- grandchild") Supported syntax: ``` - *bold* (single asterisks, not **) - _italic_ - ~strikethrough~ - `inline code` and ```code blocks``` - Bulleted lists ("* " or "- " at line start) - Links: <url|display text> (not [text](url)) - User mentions: <users/{user}> ``` Unsupported syntax (must be converted or avoided): ``` - **double asterisks** for bold - # headings - [text](url) markdown links - > blockquotes ```
da5210e to
a8743f8
Compare
Partially addresses
#58 (Chat formatting task).
Testing:
**bold**and__bold__to*bold**italic*to_italic_[text](url)to<url|text>Supported syntax:
Unsupported syntax (must be converted or avoided):