Skip to content

feat: use local browsers by default #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat: use local browsers by default #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions __fixtures/config/jsConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = {
gridUrl: 'http://localhost:4444/wd/hub',
gridUrl: 'local',
baseUrl: 'http://localhost',
pageLoadTimeout: 0,
httpTimeout: 60000,
Expand All @@ -11,17 +11,23 @@ module.exports = {
'testplane-tests/**/*.testplane.(t|j)s'
],
browsers: [
'chrome'
'chrome',
'firefox'
]
}
},
browsers: {
chrome: {
automationProtocol: 'devtools',
headless: true,
desiredCapabilities: {
browserName: 'chrome'
}
},
firefox: {
headless: true,
desiredCapabilities: {
browserName: 'firefox'
}
}
}
};
12 changes: 9 additions & 3 deletions __fixtures/config/withEverything.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import path from "path";
const isCi = Boolean(process.env.CI);

export default {
gridUrl: "http://localhost:4444/wd/hub",
gridUrl: "local",
baseUrl: "http://localhost",
pageLoadTimeout: 0,
httpTimeout: 60000,
Expand All @@ -16,17 +16,23 @@ export default {
"testplane-tests/**/*.testplane.(t|j)s"
],
browsers: [
"chrome"
"chrome",
"firefox"
]
}
},
browsers: {
chrome: {
automationProtocol: "devtools",
headless: true,
desiredCapabilities: {
browserName: "chrome"
}
},
firefox: {
headless: true,
desiredCapabilities: {
browserName: "firefox"
}
}
},
plugins: {
Expand Down
2 changes: 1 addition & 1 deletion src/constants/baseGeneralPrompts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const baseGeneralPrompts: GeneralPrompt[] = [
type: "input",
name: "gridUrl",
message: "GridUrl",
default: "http://localhost:4444/wd/hub",
default: "local",
},
{
type: "confirm",
Expand Down
11 changes: 8 additions & 3 deletions src/constants/defaultTestplaneConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { TestplaneConfig } from "../types/testplaneConfig";
export const defaultTestplaneTestsDir = "testplane-tests";

const defaultTestplaneConfig: TestplaneConfig = {
gridUrl: "http://localhost:4444/wd/hub",
gridUrl: "local",
baseUrl: "http://localhost",

pageLoadTimeout: 0,
Expand All @@ -14,18 +14,23 @@ const defaultTestplaneConfig: TestplaneConfig = {
sets: {
desktop: {
files: [`${defaultTestplaneTestsDir}/**/*.testplane.(t|j)s`],
browsers: ["chrome"],
browsers: ["chrome", "firefox"],
},
},

browsers: {
chrome: {
automationProtocol: "devtools",
headless: true,
desiredCapabilities: {
browserName: "chrome",
},
},
firefox: {
headless: true,
desiredCapabilities: {
browserName: "firefox",
},
},
},
};

Expand Down
Loading