fix(ct): run vite server once on init #1166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
force-pushed
the
TESTPLANE-790.run_vite_server_once
branch
2 times, most recently
from
9071824 to
d9dfdec
Compare
commit: |
DudaGod
force-pushed
the
TESTPLANE-790.run_vite_server_once
branch
from
d9dfdec to
f50861f
Compare
DudaGod
commented
Nov 12, 2025
|
|
||
| await this._server.listen(); | ||
|
|
||
| this._useBaseUrlFromVite(); |
Member
Author
There was a problem hiding this comment.
moved here from src/runner/browser-env/index.ts (which is not needed anymore)
| return this._server?.resolvedUrls!.local[0]; | ||
| } | ||
|
|
||
| private _useBaseUrlFromVite(): void { |
Member
Author
There was a problem hiding this comment.
also moved from src/runner/browser-env/index.ts
|
|
||
| const RunnerClass = isRunInNodeJsEnv(this._config) | ||
| ? await import("./runner").then(m => m.MainRunner) | ||
| : await import("./runner/browser-env").then(m => m.MainRunner); |
Member
Author
There was a problem hiding this comment.
browser-env runner is not needed anymore, I removed it
| @@ -1,51 +0,0 @@ | |||
| import { ViteServer } from "./vite/server"; | |||
Member
Author
There was a problem hiding this comment.
is not needed anymore because now I run vite server on init
sipayRT
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.