Merged
Conversation
added 2 commits
December 18, 2025 15:57
commit: |
shadowusr
reviewed
Dec 18, 2025
test/src/test-reader/test-parser.js
Outdated
| }); | ||
|
|
||
| describe("if set", () => { | ||
| describe.only("if set", () => { |
| ]), | ||
| parent: { | ||
| fullTitle: () => "Some parent", | ||
| tags: new Map([]), |
Member
There was a problem hiding this comment.
Shouldn't it be Set?
Also, as far as I can tell, the bug was that if parent has tag "smoke" and we ran testplane with !smoke, the test would still launch, because it was enough to get ok only from children. But here you just add an empty array, is this really sufficient to test the case we uncovered now?
Contributor
Author
There was a problem hiding this comment.
we use map for understanding dynamic tag or not, in key we have a tag name in value true or false
| } else { | ||
| current = current.parent; | ||
| } | ||
| [...current.tags.keys()].forEach(item => allTags.add(item)); |
Member
There was a problem hiding this comment.
why keys()? I know it's an alias in set for values, or we actually use Map for tags? It's becoming hard to follow, i think we should use either Map or Set everywhere for tags.
added 2 commits
December 18, 2025 16:35
shadowusr
approved these changes
Dec 18, 2025
sonic16x
deleted the
users/rocketraccoon/TESTPLANE-837.tags-no-oprator-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.