fix(selectivity): remove multi-thread hashes protection#1191
Merged
KuznetsovRoman merged 1 commit intomasterfrom Jan 16, 2026
Merged
Conversation
commit: |
KuznetsovRoman
commented
Jan 16, 2026
| markAsCommited(updatedFiles, this._stagedFileHashes); | ||
| } catch (err) { | ||
| await releaseLock(); | ||
| await writeJsonWithCompression(this._selectivityHashesPath, existingHashesContent, this._compresion); |
Member
Author
There was a problem hiding this comment.
- It existed in order to protect "hashes.json" file from writing from multiple concurrent threads (when it was the case)
- It is HashWriter.commit method
- Its only used in "updateSelectivityHashes" function
- "updateSelectivityHashes" is only run in
src/testplane.tsin master - So, we dont need this lock
KuznetsovRoman
commented
Jan 16, 2026
| ...Object.values(this._stagedPatternHashes), | ||
| ]); | ||
|
|
||
| const releaseLock = await lockfile.lock(this._selectivityHashesPath, { |
Member
Author
There was a problem hiding this comment.
Only removed this line and "releaseLock" usage
DudaGod
approved these changes
Jan 16, 2026
KuznetsovRoman
deleted the
INFRADUTY-29746.selectivity_write_hashes_without_lock
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.