fix(selectivity): add tests to run synchronously#1193
Merged
KuznetsovRoman merged 1 commit intomasterfrom Jan 22, 2026
Merged
Conversation
commit: |
KuznetsovRoman
force-pushed
the
INFRADUTY-29746.selectivity_seq_run
branch
from
c8868f4 to
310ce68
Compare
KuznetsovRoman
commented
Jan 21, 2026
|
|
||
| if (shouldDisableBrowserSelectivity) { | ||
| return this._runTestFn(test, browserId); | ||
| return [test, browserId]; |
Member
Author
There was a problem hiding this comment.
Before:
Add test to run asynchronously as soon as we find out it needs to be run
After:
Store tests we need to run, and actually add them to run synchronously, after we process all tests
| private readonly _opts?: SelectivityRunnerOptions; | ||
| private readonly _browserSelectivityDisabledCache: Record<string, void | Promise<boolean>> = {}; | ||
| private readonly _processingTestPromises: Promise<void>[] = []; | ||
| private readonly _processingTestPromises: Promise<[Test, string] | null>[] = []; |
Member
Author
There was a problem hiding this comment.
I use the same "_processingTestPromises" so we don't have to waste memory on extra "pending tests" storage
KuznetsovRoman
force-pushed
the
INFRADUTY-29746.selectivity_seq_run
branch
from
310ce68 to
3e19fae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.