fix: support repl mode in new version of vscode/cursor #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Dec 25, 2025
| }, | ||
| "peerDependencies": { | ||
| "testplane": ">8.20.0" | ||
| "testplane": ">=8.39.0" |
Member
Author
There was a problem hiding this comment.
Maybe it looks like major change, but without new version of testplane repl mode doesn't work anymore. So I decided to update the dependencies.
src/api/runner.ts
Outdated
|
|
||
| private _openReplTerminal(port: string): void { | ||
| const handler = (data: Buffer): void => { | ||
| if (!data.toString().includes("You have entered to REPL mode via terminal")) { |
Member
Author
There was a problem hiding this comment.
I haven't found another convenient way to wait for the repl to run in the testplane yet. What options have I considered:
- overwrite
switchToReplcommand, but this code run in vscode process (not in testplane) it means I should send browser instance by ipc and it doesn't work, because I can't send heavy structure like browser instance. I can useattach, but it also hard to use (I should get all capabilieties and options) - waiting for the port to start. The solution is a bit more complicated, but it doesn't rely on testplane logs, which are not a public api and can change at any time
It seems the second option is better than the current solution (parse process stdout). I'll redo it
DudaGod
force-pushed
the
TESTPLANE-739.fix_repl_mode
branch
from
169b989 to
e22794a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.