Skip to content

fix: dont use got retries #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KuznetsovRoman merged 1 commit into from
Jun 23, 2025
Merged

fix: dont use got retries #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/webdriver/src/request/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export default abstract class WebDriverRequest extends EventEmitter {
log.info('DATA', transformCommandLogResult(fullRequestOptions.json))
}

const { url, ...requestLibOptions } = fullRequestOptions
const { url, retry: _, ...requestLibOptions } = fullRequestOptions
Copy link
Member Author

@KuznetsovRoman KuznetsovRoman Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition excludes "retry" property from "requestLibOptions", so that "retry" doesn't get passed into "got", which removes "got" retries

const startTime = this._libPerformanceNow()
let response = await this._libRequest(url!, requestLibOptions)
.catch((err: RequestLibError) => err)
Expand Down
Loading