Skip to content

fix: race condition with cdp mocks #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KuznetsovRoman merged 1 commit into from
Dec 29, 2025
Merged

fix: race condition with cdp mocks #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/webdriverio/src/utils/interception/devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ export default class DevtoolsInterception extends Interception {

static handleRequestInterception (client: CDPSession, mocks: Set<Interception>): (event: Event) => Promise<void | ClientResponse> {
return async (event) => {
// Race condition: if mock was already restored on client side
// But browser managed to send "Fetch.requestPaused" event before it received "Fetch.disable"
// Client-side "mocks" is already cleaned up, but browser is waiting for request instructions
// In this case we have to send "Fetch.continueRequest" to browser and do nothing more
if (!mocks) {
return client.send('Fetch.continueRequest', { requestId: event.requestId }).catch(/* istanbul ignore next */logFetchError)
}

// responseHeaders and responseStatusCode are only present in Response stage
// https://chromedevtools.github.io/devtools-protocol/tot/Fetch/#event-requestPaused
const isRequest = !event.responseHeaders && !event.responseErrorReason
Expand Down
Loading