-
Notifications
You must be signed in to change notification settings - Fork 203
Updating to latest release of raylib #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to latest release of raylib #522
Conversation
…en2brain/raylib-go.
…ndows to test-sdl CI job. Added test-sdl3 CI job.
|
I added a sdl_shim.h which enables compiling with sdl2. Previously was failing with |
|
It has always been able to compile for SDL2 and, recently, for SDL3. But rcore_desktop_sdl.c changed, that happens on every update, everything changes. See the history, etc. Does raylib use that shim.h? If not, then the issue is elsewhere, and we should not hack it or add unnecessary files. |
|
It seems the issue was possibly introduced upstream in https://github.com/raysan5/raylib/pull/5176/files since this is using SDL3 specific code. In order to get SDL2 to work with it, the shim was created. |
|
I've created raysan5/raylib#5403 for some guidance. |
…atformHere_sdl.go files to originals.
|
@gen2brain, I've made some updates to this PR. The issue that I was attempting to fix with the shim has been corrected upstream in raylib which I've updated in raylib-go. All jobs in the package's workflow passed in my latest commit @ https://github.com/damntourists/raylib-go/actions/runs/20114236373. Could you take a look and let me know if there's anything I've missed? |
|
Nice. Please check #472; a few things must always be changed manually. Also, I think I saw in some raylib commits that something changed for the Android main entry point, but I'm not sure; I do not have time to check now. |
…ntrypoint in rcore_android.c per 5ed7905.
|
Okay, I've gone through and added the ALIGN def/undef block to jar_mx.h, the !noaudio build tag to raudio.c and updated the entry point for rcore_android.c. Whenever you get a moment, could you check on your end if there's anything I've missed? The unittests are still passing on my fork. |
|
Nice, thanks for working on this. I am merging it; it looks good. It is always good to do this, and it is much easier later on a new release. Users still get the latest tagged release; they do not have to use main/master. |
This PR adds all of the latest updates from https://github.com/raysan5/raylib which I've also confirmed as a fix for #521.