Open
Conversation
kltm
approved these changes
May 24, 2018
Member
kltm
left a comment
kltm
left a comment
There was a problem hiding this comment.
AFACT, the metadata changes look as described.
Member
|
UPDATE sorry ignore previous comments I thought the PR was for another issue OK remind me of the motivation here - this is to reduce the time it takes to run the pipeline, reducing duplicate processing? |
Member
|
I assume this can be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves all the paint dataset yaml into a new field in the standard group dataset yaml. Now for some dataset in a group , if there is was a paint source paint_, now the metadata for paint_ will be in dataset entry.
The datasets schema has been updated to reflect this.
There needs to be a corresponding ontobio change to read the metadata files, which exists here: biolink/ontobio#180
There is a test run in Jenkins here: https://build.geneontology.org/job/geneontology/job/pipeline/job/splitting_paint_iteration/2/
Lastly, the order of operations for this is to merge ontobio, release 1.1.0, and then merge this PR. This should be done right after another though, so they remain in sync.