Make pbars respect logging levels #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #100 and #101 by disabling pbars in sampling if the logging level is greater than
INFO.I did try
logging_redirect_tqdmbut it does not address the desired behavior, and in any case we already haveshow_progressfor this purpose.The main downside of this approach is that
logging_leveloverridesshow_progress.We also use pbars for ollama downloads. I argue against disabling those pbars because in that case the user will observe "hanging" if a model needs to be downloaded. Also, this should happen only rarely and only for local inference users, so the typical situations where you want quiet
STDOUTdo not apply.