Skip to content

Conversation

@nrfulton
Copy link
Contributor

This PR addresses #100 and #101 by disabling pbars in sampling if the logging level is greater than INFO.

I did try logging_redirect_tqdm but it does not address the desired behavior, and in any case we already have show_progress for this purpose.

The main downside of this approach is that logging_level overrides show_progress.

We also use pbars for ollama downloads. I argue against disabling those pbars because in that case the user will observe "hanging" if a model needs to be downloaded. Also, this should happen only rarely and only for local inference users, so the typical situations where you want quiet STDOUT do not apply.

Does not show pbar during sampling if effective logging level is greater
than INFO.
@nrfulton nrfulton requested a review from avinash2692 August 26, 2025 23:21
@avinash2692 avinash2692 merged commit d92a44f into main Aug 27, 2025
3 checks passed
@nrfulton nrfulton deleted the fix/100 branch August 27, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants