-
Notifications
You must be signed in to change notification settings - Fork 53
feat: Conda/Mamba-based installation script #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
5878e00 to
9aedf80
Compare
jakelorocco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good to me; left one comment about the actual script. I think we should get input from the rest of the team on what they want a scripts or conda directory to look like before merging this.
2e42ca0 to
755d400
Compare
| Fork and clone the repositoy: | ||
| ```bash | ||
| git clone ssh://[email protected]/<my-username>/mellea.git && cd mellea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we are forcing them to fork it? It might be easier to just have them install from our github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops didnt notice it before merging.
* feat: conda or mamba-based installation script * docs: conda-based installation script * fix: reflect README * feat: getopts for -h option * feat: detects an existing mellea environment and try to remove it * feat: added -y option * fix: enforce VLLM_USE_V1 = 0
script separated in conda/ directory