Skip to content

Conversation

@guicho271828
Copy link
Contributor

script separated in conda/ directory

@mergify
Copy link

mergify bot commented Sep 12, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@guicho271828 guicho271828 force-pushed the conda branch 2 times, most recently from 5878e00 to 9aedf80 Compare September 12, 2025 16:19
Copy link
Contributor

@jakelorocco jakelorocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good to me; left one comment about the actual script. I think we should get input from the rest of the team on what they want a scripts or conda directory to look like before merging this.

Fork and clone the repositoy:
```bash
git clone ssh://[email protected]/<my-username>/mellea.git && cd mellea/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we are forcing them to fork it? It might be easier to just have them install from our github?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops didnt notice it before merging.

@guicho271828 guicho271828 merged commit 6aea9dc into generative-computing:main Nov 3, 2025
4 checks passed
@guicho271828 guicho271828 deleted the conda branch November 3, 2025 18:43
tuliocoppola pushed a commit to tuliocoppola/mellea that referenced this pull request Nov 5, 2025
* feat: conda or mamba-based installation script

* docs: conda-based installation script

* fix: reflect README

* feat: getopts for -h option

* feat: detects an existing mellea environment and try to remove it

* feat: added -y option

* fix: enforce VLLM_USE_V1 = 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants