fix: rename format argument in internal methods for better mypiability #172
+66
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
guicho271828
force-pushed
the
masa/rename-format-argument-for-internal-methods
branch
2 times, most recently
from
536c1a7 to
8af76a9
Compare
nrfulton
reviewed
Oct 10, 2025
Contributor
nrfulton
left a comment
nrfulton
left a comment
There was a problem hiding this comment.
If we decide to go ahead with this, then lgtm. I wonder if there's a better way?
jakelorocco
reviewed
Oct 10, 2025
Contributor
jakelorocco
left a comment
jakelorocco
left a comment
There was a problem hiding this comment.
I wonder if we even need to shadow the global format variable. Now that the functions have _format for their parameters, my IDE colors format differently than _format.
…so that mypy detects it
guicho271828
force-pushed
the
masa/rename-format-argument-for-internal-methods
branch
from
365d3bc to
db1e514
Compare
jakelorocco
approved these changes
Oct 16, 2025
tuliocoppola
pushed a commit
to tuliocoppola/mellea
that referenced
this pull request
Nov 5, 2025
generative-computing#172) * refactor: renamed 'format' variable to '_format' in internal methods so that mypy detects it * fix: use format = None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy fails to check
formatvariable passed around in backends due to the built-in global binding toformat.This PR renames it for private internal methods. No changes to the public API.
Merge this after #135 .
@jakelorocco