-
Notifications
You must be signed in to change notification settings - Fork 49
Implemented new is_appellate_case verifier for legal applications, ad… #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hannahTao
wants to merge
4
commits into
generative-computing:main
Choose a base branch
from
hannahTao:hannah-legal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3a43860
Implemented new is_appellate_case verifier for legal applications, ad…
a7a4569
moved files to right directories, created new function for loading JS…
6d40592
changed data types to be of mellea (e.g. ValidationResult, Context) i…
60bdc49
clarified exceptions list in comment and variable name
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import json | ||
| import os | ||
|
|
||
| from mellea.stdlib.requirement import Requirement | ||
|
|
||
|
|
||
| def get_court_from_case(case_name, folder_path): | ||
| files = os.listdir(folder_path) | ||
| for file_path in files: | ||
| with open(os.path.join(folder_path, file_path)) as file: | ||
| data = json.load(file) | ||
| for entry in data: | ||
| if case_name.lower() in entry["name"].lower(): | ||
| return entry["court"]["name"] | ||
|
|
||
|
|
||
| def is_appellate_court(court_name): | ||
| lowered_name = court_name.lower() | ||
| exceptions = ["pennsylvania superior court", "pennsylvania commonwealth court"] | ||
|
||
| keywords = ["supreme", "appeal", "appellate"] | ||
| return ( | ||
| any(keyword in lowered_name for keyword in keywords) | ||
| or lowered_name in exceptions | ||
| ) | ||
|
|
||
|
|
||
| class IsAppellateCase(Requirement): | ||
| def __init__(self, folder_path): | ||
| self.folder_path = folder_path | ||
| super().__init__( | ||
| description="The result should be an appellate court case.", | ||
| validation_fn=lambda x: is_appellate_court( | ||
| get_court_from_case(x, folder_path) | ||
| ), | ||
| ) | ||
|
|
||
|
|
||
| class IsDistrictCase(Requirement): | ||
| def __init__(self, folder_path): | ||
| self.folder_path = folder_path | ||
| super().__init__( | ||
| description="The result should be a district court case.", | ||
| validation_fn=lambda x: not is_appellate_court( | ||
| get_court_from_case(x, folder_path) | ||
| ), | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import pytest | ||
| from is_appellate_case import get_court_from_case, is_appellate_court | ||
|
|
||
| from mellea import start_session | ||
| from mellea.stdlib.requirement import req, simple_validate | ||
| from mellea.stdlib.sampling import RejectionSamplingStrategy | ||
|
|
||
|
|
||
| def test_is_appellate_court_test(): | ||
| assert is_appellate_court("Supreme Court of New Jersey") is True | ||
| assert is_appellate_court("Tax Court of New Jersey") is False | ||
| assert is_appellate_court("Pennsylvania Commonwealth Court") is True | ||
| assert is_appellate_court("U.S. Court of Appeals for the First Circuit") is True | ||
| assert is_appellate_court("Maryland Appellate Court") is True | ||
| assert is_appellate_court("District Court of Maryland") is False | ||
|
|
||
|
|
||
| def test_appellate_case_session(): | ||
| case_name = "ARTHUR DeMOORS, PLAINTIFF-RESPONDENT, v. ATLANTIC CASUALTY INSURANCE COMPANY OF NEWARK, NEW JERSEY, A CORPORATION, DEFENDANT-APPELLANT" | ||
| folder_path = "nj_case_metadata" | ||
|
|
||
| m = start_session() | ||
| appellate_case = m.instruct( | ||
| f"Return the following string (only return the characters after the colon, no other words): {case_name}", | ||
| requirements=[ | ||
| req( | ||
| "The result should be an appellate court case", | ||
| validation_fn=simple_validate( | ||
| lambda x: is_appellate_court(get_court_from_case(x, folder_path)) | ||
| ), | ||
| ) | ||
| ], | ||
| strategy=RejectionSamplingStrategy(loop_budget=5), | ||
| return_sampling_results=True, | ||
| ) | ||
| assert "SUCCESS" in appellate_case |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operate over strings, not files, in the stdlib.