-
Notifications
You must be signed in to change notification settings - Fork 53
feat: LiteLLM backend #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cleanup and tracking with main still needs to be done. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
# Conflicts: # pyproject.toml # uv.lock
fixing model option cleanup
|
looks like the test that failed only fails intermittently (and isn't related to this PR); opened a separate issue to track it: #121 |
jakelorocco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments on tools and tests; the rest lgtm after chatting about unknown model_options
jakelorocco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the litellm tests are failing; I'm not sure if it's a limitation with litellm / ollama. the rest lgtm
test/backends/test_litellm_ollama.py::test_litellm_ollama_chat XFAIL [ 10%]
test/backends/test_litellm_ollama.py::test_litellm_ollama_instruct XFAIL [ 11%]
test/backends/test_litellm_ollama.py::test_litellm_ollama_instruct_options XFAIL [ 11%]
nrfulton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think that's consistent with the |
# Conflicts: # uv.lock
Dismissing so it's not needed when things are fixed.
|
merging after fixing some merge-issue |
No description provided.