Skip to content

Conversation

@HendrikStrobelt
Copy link
Contributor

No description provided.

@HendrikStrobelt
Copy link
Contributor Author

cleanup and tracking with main still needs to be done.

@nrfulton nrfulton self-requested a review August 27, 2025 17:13
@HendrikStrobelt HendrikStrobelt changed the title Started light LLM backend Started LiteLLM backend Sep 2, 2025
@mergify
Copy link

mergify bot commented Sep 3, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

@HendrikStrobelt HendrikStrobelt changed the title Started LiteLLM backend Feature: LiteLLM backend Sep 4, 2025
@HendrikStrobelt HendrikStrobelt changed the title Feature: LiteLLM backend feat: LiteLLM backend Sep 4, 2025
@HendrikStrobelt HendrikStrobelt marked this pull request as ready for review September 4, 2025 19:52
@jakelorocco
Copy link
Contributor

looks like the test that failed only fails intermittently (and isn't related to this PR); opened a separate issue to track it: #121

Copy link
Contributor

@jakelorocco jakelorocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments on tools and tests; the rest lgtm after chatting about unknown model_options

Copy link
Contributor

@jakelorocco jakelorocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the litellm tests are failing; I'm not sure if it's a limitation with litellm / ollama. the rest lgtm

test/backends/test_litellm_ollama.py::test_litellm_ollama_chat XFAIL     [ 10%]
test/backends/test_litellm_ollama.py::test_litellm_ollama_instruct XFAIL [ 11%]
test/backends/test_litellm_ollama.py::test_litellm_ollama_instruct_options XFAIL [ 11%]

Copy link
Contributor

@nrfulton nrfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HendrikStrobelt
Copy link
Contributor Author

looks like the litellm tests are failing; I'm not sure if it's a limitation with litellm / ollama. the rest lgtm

test/backends/test_litellm_ollama.py::test_litellm_ollama_chat XFAIL     [ 10%]
test/backends/test_litellm_ollama.py::test_litellm_ollama_instruct XFAIL [ 11%]
test/backends/test_litellm_ollama.py::test_litellm_ollama_instruct_options XFAIL [ 11%]

I think that's consistent with the @pytest.mark.qualitative annotations of other backend tests (wtasonx, openai, .. )

@jakelorocco jakelorocco changed the base branch from main to feat/logo_update September 8, 2025 21:06
@jakelorocco jakelorocco changed the base branch from feat/logo_update to main September 8, 2025 21:06
@jakelorocco jakelorocco dismissed their stale review September 8, 2025 21:10

Dismissing so it's not needed when things are fixed.

@HendrikStrobelt
Copy link
Contributor Author

merging after fixing some merge-issue

@HendrikStrobelt HendrikStrobelt merged commit 61d7f0e into main Sep 8, 2025
4 checks passed
@HendrikStrobelt HendrikStrobelt deleted the hen/litellm_310 branch September 10, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants