Skip to content

Conversation

@jakelorocco
Copy link
Contributor

@jakelorocco jakelorocco commented Aug 20, 2025

Closes: #20

Ended up being a relatively small change. And added a test to make sure we weren't editing the original requirement.

Previously, we would append the output directly to the requirement that was being used for validation. Now, we create a copy of that action (this is similar to what we do for genslots and sampling already).

I considered switching back to the old Validation object and having that store the output from the llmaj / requirement, but that no longer works with how we are handling aloras. Since backends now detect alora requirements and do specific actions based on the class type, we must pass an alora requirement in those situations. I didn't want to add another level of complexity and force requirement contributors to always write two components (a requirement and a validation).

If we switch back to having requirements handle their own processing / routing, then we should switch to having a Validation object.

All tests pass.

Copy link
Contributor

@nrfulton nrfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakelorocco jakelorocco merged commit 4819407 into main Aug 21, 2025
3 checks passed
@jakelorocco jakelorocco deleted the jal/req-thread-safety branch August 21, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make requirements thread-safe

3 participants