Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #20
Ended up being a relatively small change. And added a test to make sure we weren't editing the original requirement.
Previously, we would append the output directly to the requirement that was being used for validation. Now, we create a copy of that action (this is similar to what we do for genslots and sampling already).
I considered switching back to the old
Validationobject and having that store the output from the llmaj / requirement, but that no longer works with how we are handling aloras. Since backends now detect alora requirements and do specific actions based on the class type, we must pass an alora requirement in those situations. I didn't want to add another level of complexity and force requirement contributors to always write two components (a requirement and a validation).If we switch back to having requirements handle their own processing / routing, then we should switch to having a Validation object.
All tests pass.